test(ci, perf): use macos-14 runner / iPhone 15 in CI

the new apple silicon runner should be substantially faster,
additionally we should switch to an iPhone definition that is
included by default in Xcode 15 since we're moving all the way
from macos-12 to macos-14 runner and the Xcode (with its simulator
definitions) is jumping versions

Author: mikehardy

.github/workflows/tests_e2e_ios.yml

@@ -27,18 +27,12 @@ concurrency:
 jobs:
   ios:
     name: iOS
-    runs-on: macos-12
+    runs-on: macos-14
     # TODO matrix across APIs, at least 11 and 15 (lowest to highest)
     timeout-minutes: 100
     env:
       CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
     steps:
-      # macOS13 runners are slooooow
-      # This is from: https://github.com/actions/runner-images/issues/7971#issuecomment-1824430407
-      - name: macOS-13-runner speedup
-        run: |
-          sudo launchctl unload -w /System/Library/LaunchDaemons/com.apple.diagnosticd.plist
-
       # Set up tool versions
       - uses: actions/setup-node@v3
         with:

tests/package.json

@@ -63,15 +63,15 @@
         "build": "set -o pipefail && xcodebuild VALID_ARCHS=\"`uname -m`\"  CC=clang CPLUSPLUS=clang++ LD=clang LDPLUSPLUS=clang++ -workspace ios/testing.xcworkspace -scheme testing -configuration Debug -sdk iphonesimulator -derivedDataPath ios/build | xcbeautify",
         "type": "ios.simulator",
         "device": {
-          "type": "iPhone 14"
+          "type": "iPhone 15"
         }
       },
       "ios.sim.release": {
         "binaryPath": "ios/build/Build/Products/Release-iphonesimulator/testing.app",
         "build": "export RCT_NO_LAUNCH_PACKAGER=true && set -o pipefail | xcodebuild  CC=clang CPLUSPLUS=clang++ LD=clang LDPLUSPLUS=clang++ -workspace ios/testing.xcworkspace -scheme testing -configuration Release -sdk iphonesimulator -derivedDataPath ios/build | xcbeautify",
         "type": "ios.simulator",
         "device": {
-          "type": "iPhone 14"
+          "type": "iPhone 15"
         }
       },
       "android.emu.debug": {