Skip to content

Replace np.Inf with np.inf in tests#98

Merged
jbschiratti merged 1 commit intomne-tools:masterfrom
rcmdnk:np_inf
Oct 17, 2025
Merged

Replace np.Inf with np.inf in tests#98
jbschiratti merged 1 commit intomne-tools:masterfrom
rcmdnk:np_inf

Conversation

@rcmdnk
Copy link
Collaborator

@rcmdnk rcmdnk commented Oct 15, 2025

The np.Inf alias was removed in NumPy 2.0:

https://numpy.org/doc/stable/release/2.0.0-notes.html#numpy-2-0-python-api-removals

For Python 3.9 and later, the latest supported NumPy release is version 2.0 or higher.

Some tests still use np.Inf, so these should be replaced with np.inf for compatibility with NumPy 2.0 and later.

@rcmdnk
Copy link
Collaborator Author

rcmdnk commented Oct 15, 2025

Tests will not start because the GitHub Actions workflow is outdated.
They will work after #99 is merged.

Copy link
Collaborator

@jbschiratti jbschiratti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Feel free to merge it

@rcmdnk
Copy link
Collaborator Author

rcmdnk commented Oct 17, 2025

@hubertjb ((sorry for the wrong mention))
@jbschiratti
Thank you for the review.

It seems I don’t have the permission to merge this PR.
Could you please merge it for me?

@jbschiratti jbschiratti merged commit b0f1849 into mne-tools:master Oct 17, 2025
rcmdnk added a commit to rcmdnk/mne-features that referenced this pull request Oct 19, 2025
@rcmdnk rcmdnk deleted the np_inf branch October 21, 2025 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants