FIX: Test environments with only torch or onnxruntime installed#271
Merged
mscheltienne merged 11 commits intomne-tools:mainfrom Oct 17, 2025
Merged
FIX: Test environments with only torch or onnxruntime installed#271mscheltienne merged 11 commits intomne-tools:mainfrom
mscheltienne merged 11 commits intomne-tools:mainfrom
Conversation
scott-huberty
changed the title
scott-huberty
commented
Oct 16, 2025
mscheltienne
requested changes
Oct 17, 2025
Member
mscheltienne
left a comment
mscheltienne
left a comment
There was a problem hiding this comment.
Thanks @scott-huberty for the excellent catch. A couple of comments, but beside it LGTM! This PR will have to be backported and released.
This reverts commit 49d678f.
Co-authored-by: Mathieu Scheltienne <mathieu.scheltienne@gmail.com>
Contributor
Author
Done in 376de91 |
Contributor
Author
|
OK passing it back to you @mscheltienne 🙂 |
mscheltienne
approved these changes
Oct 17, 2025
Member
|
Thanks a lot! |
mscheltienne
added a commit
that referenced
this pull request
Oct 17, 2025
* Drop torch and onnx variants from text extras * Test CI's in environments with either torch or onnxruntime installed * TST: import or skip * FIX: oops need to capture output of importorskip * FIX: dep * DOC: Note for Megnet users * FIX, DOC: flaky link * Revert "FIX, DOC: flaky link" This reverts commit 49d678f. * TST: Add backend job * Update doc/install.rst Co-authored-by: Mathieu Scheltienne <mathieu.scheltienne@gmail.com> * FIX, STY: Flakes --------- Co-authored-by: Mathieu Scheltienne <mathieu.scheltienne@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
Fixes #270
Merge checklist
Maintainer, please confirm the following before merging: