Open
Conversation
Member
|
thanks please try to make travis happy and let us know when he is so we can review. |
Collaborator
|
my 2 cents:
|
Collaborator
|
Just a note that connectivity has since been moved from |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi all,
This is a duplicate of my mne-python PR, where I propose an expansion of the scope of mne-python's functional connectivity (FC) measures. I have just started my PhD and am working on EEG-based Connectomics, so it is ideal for me to incorporate my connectivity code to the mne-python package over the next few years.
Correlation-based and mutual information-based measures are quite common in the literature and easy to implement, so I've submitted some examples of those first. A good reference for FC measures is Wang et al (2014) "A systematic framework for functional connectivity measures."
For now, I will plan to continually implement various FC measures as I've found in the literature while awaiting discussion on where to take this. I will also continue learning the mne-python API so I can integrate my code better.
Again, ideally it would make sense to have measures from the 7 major categories of FC measures. The current functionality from "spectral.py" belongs to the 4th category in my understanding:
To note, I would also like to incorporate dynamic functional connectivity (FC over multiple epochs) and more causal effective connectivity, so an entire discussion on connectivity overall might be worthwhile.
Best
Nick