Skip to content

do not log about using set_montage AGAIN if it has never been used #12984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
larsoner merged 3 commits into from
Nov 22, 2024
Merged

do not log about using set_montage AGAIN if it has never been used #12984

larsoner merged 3 commits into from
Nov 22, 2024

Conversation

@sappelhoff
Copy link
Member

@sappelhoff sappelhoff commented Nov 22, 2024

@sappelhoff sappelhoff requested a review from larsoner November 22, 2024 15:10
@larsoner larsoner enabled auto-merge (squash) November 22, 2024 16:38
@larsoner
Copy link
Member

larsoner commented Nov 22, 2024

Marking for merge-when-green, thanks in advance @sappelhoff !

@larsoner
Copy link
Member

larsoner commented Nov 22, 2024

Failure looks related

_____________________________ test_add_reorder[2] ______________________________
E   Failed: DID NOT WARN. No warnings of type (<class 'RuntimeWarning'>,) matching the regex were emitted.
     Regex: locations of multiple
     Emitted warnings: [ RuntimeWarning('Location for this channel is unknown or ambiguous; consider calling set_montage() after adding new reference channels if needed. Applying a montage will only set locations of channels that exist at the time it is applied.')].
All traceback entries are hidden. Pass `--full-trace` to see hidden and internal frames.

During handling of the above exception, another exception occurred:
mne/_fiff/tests/test_reference.py:900: in test_add_reorder
    with ctx:
E   RuntimeWarning: Location for this channel is unknown or ambiguous; consider calling set_montage() after adding new reference channels if needed. Applying a montage will only set locations of channels that exist at the time it is applied.

@larsoner larsoner merged commit 57076c9 into mne-tools:main Nov 22, 2024
24 checks passed
@sappelhoff sappelhoff deleted the log branch November 22, 2024 19:43
larsoner added a commit to larsoner/mne-python that referenced this pull request Dec 6, 2024
@larsoner
Merge remote-tracking branch 'upstream/main' into cola5
0adefdf 
* upstream/main: (736 commits)
  ENH: Add round-trip channel name saving (mne-tools#13003)
  update governance (mne-tools#12896)
  pin selenium and stop filtering its warning (mne-tools#13000)
  DOC: fix return value doc of inst.get_montage() (mne-tools#12995)
  remove some ._filenames uses in favor of .filenames (mne-tools#12996)
  use eegbci.standardize instead of custom code (mne-tools#12997)
  Bump autofix-ci/action from dd55f44df8f7cdb7a6bf74c78677eb8acd40cd0a to ff86a557419858bb967097bfc916833f5647fa8c in the actions group (mne-tools#12999)
  MAINT: Update code credit (mne-tools#12998)
  MAINT: Unpin VTK (mne-tools#12991)
  [pre-commit.ci] pre-commit autoupdate (mne-tools#12988)
  Fix: update cnt.py to check missing annotation (mne-tools#12986)
  do not log about using set_montage AGAIN if it has never been used (mne-tools#12984)
  DOC: fix numpy docstr example Vectorizer() (mne-tools#12983)
  Changed epochs_clean_sub = model_plain.apply(epochs) to epochs_clean_sub = model_sub.apply(epochs), making use of the regression coefficients from model_sub. mne-tools#12977 (mne-tools#12978)
  DOC: add meegkit to related software suite (mne-tools#12976)
  DOC: specify tmax_raw param may be None, and what it means (mne-tools#12972)
  [pre-commit.ci] pre-commit autoupdate (mne-tools#12975)
  DOC: fix note in legacy pick_channels func (mne-tools#12973)
  Use `uint16_codec` argument (mne-tools#12971)
  Bump codecov/codecov-action from 4 to 5 in the actions group (mne-tools#12970)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@larsoner larsoner larsoner approved these changes

Assignees

No one assigned

Labels

no-changelog-entry-needed skip-changelog-checks

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

.add_reference_channels sends unexpected log about locations

2 participants

@sappelhoff @larsoner