"Enhancement" changed to "newfeature" in contribution guide documentation

[shristibaral]

Reference issue (if any)

Fixes #13372

What does this implement/fix?

I changed the word Enhancement to newfeature in line 617 of file contribution.rst as Enhancement is not a recognized change type.

Additional information

[drammock]

could you also fix the "devel" -> "dev" problem you mentioned in #13372 @shristibaral?

@cbrnr can you handle review of this one when it's ready?

[cbrnr]

Sure. Is the change from enhancement to newfeature OK (i.e., can Towncrier handle it)?

[shristibaral]

could you also fix the "devel" -> "dev" problem you mentioned in #13372 @shristibaral?

I think someone has already fixed it. It isn't there in the code anymore. Just in the live documentation.

[drammock]

Sure. Is the change from enhancement to newfeature OK (i.e., can Towncrier handle it)?

@cbrnr a quick scan of the filenames in doc/changes/dev shows lots of NNNNN.newfeature.rst files. So, yes.

could you also fix the "devel" -> "dev" problem you mentioned in #13372 @shristibaral?

I think someone has already fixed it. It isn't there in the code anymore. Just in the live documentation.

In that case we should backport this PR (once merged) and also the change that updated that line of the contrib guide (probably not the whole PR, just that one line). @cbrnr are you up for that?

[cbrnr]

Thanks @shristibaral!

[drammock]

@cbrnr merging is blocked until you re-review and "approve" (to cancel out the "request changes" review)

[cbrnr]

@drammock there's a failing test though, I'll restart.

[drammock]

test has failed 3 times at the same spot. Appears to be on a mkdir -p command, which is odd. May have something to do with recent migration of macos-latest to macos-15. Will investigate when I have time, if someone else doesn't beat me to it.