Skip to content

FIX: Replace np.fromstring with np.frombuffer in GDF reader for NumPy… #13415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

FIX: Replace np.fromstring with np.frombuffer in GDF reader for NumPy… #13415

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ab866f2
FIX: Replace np.fromstring with np.frombuffer in GDF reader for NumPy…
devparikh0506 Sep 11, 2025
9e9e281
FIX: Use fid.read(1) + np.frombuffer in GDF reader to replace np.from…
devparikh0506 Sep 11, 2025
4f455ee
Merge branch 'main' into fix-gdf-fromstring
devparikh0506 Sep 11, 2025
fc98279
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Sep 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions doc/changes/dev/13415.bugfix.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fixed a bug where ``mne.io.read_raw_gdf`` failed with NumPy ≥1.24 due to the removal of ``np.fromstring`` binary mode. Replaced with ``np.frombuffer`` for compatibility. (:newcontrib:`devparikh0506`)
1 change: 1 addition & 0 deletions doc/changes/names.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@
.. _David Sabbagh: https://github.com/DavidSabbagh
.. _Demetres Kostas: https://github.com/kostasde
.. _Denis Engemann: https://denis-engemann.de
.. _Dev Parikh: https://github.com/devparikh0506
.. _Dinara Issagaliyeva: https://github.com/dissagaliyeva
.. _Diptyajit Das: https://github.com/dasdiptyajit
.. _Dirk Gütlin: https://github.com/DiGyt
Expand Down
4 changes: 2 additions & 2 deletions mne/io/edf/edf.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1441,9 +1441,9 @@ def _read_gdf_header(fname, exclude, include=None):
edf_info["data_offset"] + edf_info["n_records"] * edf_info["bytes_tot"]
)
fid.seek(etp) # skip data to go to event table
etmode = fid.read(1).decode()
etmode = fid.read(1)
if etmode != "":
etmode = np.fromstring(etmode, UINT8).tolist()[0]
etmode = np.frombuffer(etmode, dtype=UINT8).tolist()[0]

if edf_info["number"] < 1.94:
sr = np.fromfile(fid, UINT8, 3)
Expand Down
Loading