Skip to content

ENH: Add hpi_colors and hpi_labels for clear visualization #13533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
drona-gyawali wants to merge 6 commits into from

refactor case

973883a
Select commit
Loading
Failed to load commit list.
Closed

ENH: Add hpi_colors and hpi_labels for clear visualization #13533

refactor case
973883a
Select commit
Loading
Failed to load commit list.
Azure Pipelines / mne-tools.mne-python failed Dec 17, 2025 in 1h 12m 29s

Build #20251217.8 had test failures

6 errors / 0 warnings

Details

Tests

  • Failed: 3 (0.03%)
  • Passed: 10,269 (98.32%)
  • Other: 172 (1.65%)
  • Total: 10,444
Code coverage

  • 31169 of 126594 line covered (24.62%)

Annotations

Check failure on line 674 in Build log

See this annotation in the file changed.

@azure-pipelines azure-pipelines / mne-tools.mne-python

Build log #L674 

Bash exited with code '1'.

Check failure on line 19 in Build log

See this annotation in the file changed.

@azure-pipelines azure-pipelines / mne-tools.mne-python

Build log #L19 

There are one or more test failures detected in result files. Detailed summary of published test results can be viewed in the Tests tab.

Check failure on line 25 in Build log

See this annotation in the file changed.

@azure-pipelines azure-pipelines / mne-tools.mne-python

Build log #L25 

There are one or more test failures detected in result files. Detailed summary of published test results can be viewed in the Tests tab.

Check failure on line 5255 in Build log

See this annotation in the file changed.

@azure-pipelines azure-pipelines / mne-tools.mne-python

Build log #L5255 

Cmd.exe exited with code '1'.

Check failure on line 1 in test_coreg_gui_pyvista_basic[pyvistaqt]

See this annotation in the file changed.

@azure-pipelines azure-pipelines / mne-tools.mne-python

test_coreg_gui_pyvista_basic[pyvistaqt] 

AttributeError: 'tuple' object has no attribute 'SetVisibility'
Raw output 
mne/gui/tests/test_coreg.py:170: in test_coreg_gui_pyvista_basic
    coreg._set_lock_fids(False)
mne/gui/_coreg.py:415: in _set_lock_fids
    self._lock_fids = bool(state)
/opt/hostedtoolcache/Python/3.10.19/x64/lib/python3.10/site-packages/traitlets/traitlets.py:716: in __set__
    self.set(obj, value)
/opt/hostedtoolcache/Python/3.10.19/x64/lib/python3.10/site-packages/traitlets/traitlets.py:706: in set
    obj._notify_trait(self.name, old_value, new_value)
/opt/hostedtoolcache/Python/3.10.19/x64/lib/python3.10/site-packages/traitlets/traitlets.py:1513: in _notify_trait
    self.notify_change(
/opt/hostedtoolcache/Python/3.10.19/x64/lib/python3.10/site-packages/traitlets/traitlets.py:1525: in notify_change
    return self._notify_observers(change)
/opt/hostedtoolcache/Python/3.10.19/x64/lib/python3.10/site-packages/traitlets/traitlets.py:1568: in _notify_observers
    c(event)
mne/gui/_coreg.py:699: in _lock_fids_changed
    self._set_sensors_visibility(self._lock_fids)
mne/gui/_coreg.py:1192: in _set_sensors_visibility
    actor.SetVisibility(state)
E   AttributeError: 'tuple' object has no attribute 'SetVisibility'

Check failure on line 1 in test_plot_alignment_hpi_colors_and_labels[pyvistaqt]

See this annotation in the file changed.

@azure-pipelines azure-pipelines / mne-tools.mne-python

test_plot_alignment_hpi_colors_and_labels[pyvistaqt] 

assert 16 == 12
 +  where 16 = len({'PolyData(Addr=0000017C9F973B30)': Actor (0x17cdf71c4c0)\n  Center:                     (0.03292274009436369, 0.09897983074188232, 0.07984329760074615)\n  Pickable:                   True\n  Position:                   (0.0, 0.0, 0.0)\n  Scale:                      (1.0, 1.0, 1.0)\n  Visible:                    False\n  X Bounds                    3.097E-02, 3.487E-02\n  Y Bounds                    9.703E-02, 1.009E-01\n  Z Bounds                    7.784E-02, 8.184E-02\n  User matrix:                Identity\n  Has mapper:                 True\n\nProperty (0x17c8139a020)\n  Ambient:                     0.0\n  Ambient color:               Color(name='red', hex='#ff0000ff', opacity=255)\n  Anisotropy:                  0.0\n  Color:                       Color(name='red', hex='#ff0000ff', opacity=255)\n  Culling:                     "back"\n  Diffuse:                     1.0\n  Diffuse color:               Color(name='red', hex='#ff0000ff', opacity=255)\n  Edge color:                  Color(name='black', hex='#000000ff', opacity=255)\n  Edge opacity:                1.0\n  Interpolation:               2\n  Lighting:                    True\n  Line width:                  1.0\n  Metallic:                    0.0\n  Opacity:                     0.5\n  Point size:                  5.0\n  Render lines as tubes:       False\n  Render points as spheres:    False\n  Roughness:                   0.5\n  Show edges:                  False\n  Specular:                    0.0\n  Specular color:              Color(name='red', hex='#ff0000ff', opacity=255)\n  Specular power:              100.0\n  Style:                       "Surface"\n\nDataSetMapper (0x17c8139a020)\n  Scalar visibility:           False\n  Scalar range:                (0.0, 1.0)\n  Interpolate before mapping:  True\n  Scalar map mode:             default\n  Color mode:                  direct\n\nAttached dataset:\nPolyData (0x17c8139bf40)\n  N Cells:    96\n  N Points:   50\n  N Strips:   0\n  X Bounds:   3.097e-02, 3.487e-02\n  Y Bounds:   9.703e-02, 1.009e-01\n  Z Bounds:   7.784e-02, 8.184e-02\n  N Arrays:   1, '1-points': Actor (0x17cd9b00a00)\n  Center:                     (0.032922741025686264, 0.09897983074188232, 0.08504329760074615)\n  Pickable:                   False\n  Position:                   (0.0, 0.0, 0.0)\n  Scale:                      (1.0, 1.0, 1.0)\n  Visible:                    True\n  X Bounds                    3.292E-02, 3.292E-02\n  Y Bounds                    9.898E-02, 9.898E-02\n  Z Bounds                    8.504E-02, 8.504E-02\n  User matrix:                Identity\n  Has mapper:                 True\n\nProperty (0x17c8139a020)\n  Ambient:                     0.0\n  Ambient color:               Color(name='lightblue', hex='#add8e6ff', opacity=255)\n  Anisotropy:                  0.0\n  Color:                       Color(name='lightblue', hex='#add8e6ff', opacity=255)\n  Culling:                     "none"\n  Diffuse:                     1.0\n  Diffuse color:               Color(name='lightblue', hex='#add8e6ff', opacity=255)\n  Edge color:                  Color(name='black', hex='#000000ff', opacity=255)\n  Edge opacity:                1.0\n  Interpolation:               0\n  Lighting:                    True\n  Line width:                  1.0\n  Metallic:                    0.0\n  Opacity:                     1.0\n  Point size:                  0.00279999990016222\n  Render lines as tubes:       False\n  Render points as spheres:    False\n  Roughness:                   0.5\n  Show edges:                  False\n  Specular:                    0.0\n  Specular color:              Color(name='lightblue', hex='#add8e6ff', opacity=255)\n  Specular power:              100.0\n  Style:                       "Surface"\n\nDataSetMapper (0x17c8139a020)\n  Scalar visibility:           False\n  Scalar range:                (0.0, 1.0)\n  Interpolate before mapping:  True\n  Scalar map mode:             default\n  Color
Raw output 
mne\viz\tests\test_3d.py:938: in test_plot_alignment_hpi_colors_and_labels
    _assert_n_actors(fig, renderer, 12)
E   assert 16 == 12
E    +  where 16 = len({'PolyData(Addr=0000017C9F973B30)': Actor (0x17cdf71c4c0)\n  Center:                     (0.03292274009436369, 0.09897983074188232, 0.07984329760074615)\n  Pickable:                   True\n  Position:                   (0.0, 0.0, 0.0)\n  Scale:                      (1.0, 1.0, 1.0)\n  Visible:                    False\n  X Bounds                    3.097E-02, 3.487E-02\n  Y Bounds                    9.703E-02, 1.009E-01\n  Z Bounds                    7.784E-02, 8.184E-02\n  User matrix:                Identity\n  Has mapper:                 True\n\nProperty (0x17c8139a020)\n  Ambient:                     0.0\n  Ambient color:               Color(name='red', hex='#ff0000ff', opacity=255)\n  Anisotropy:                  0.0\n  Color:                       Color(name='red', hex='#ff0000ff', opacity=255)\n  Culling:                     "back"\n  Diffuse:                     1.0\n  Diffuse color:               Color(name='red', hex='#ff0000ff', opacity=255)\n  Edge color:                  Color(name='black', hex='#000000ff', opacity=255)\n  Edge opacity:                1.0\n  Interpolation:               2\n  Lighting:                    True\n  Line width:                  1.0\n  Metallic:                    0.0\n  Opacity:                     0.5\n  Point size:                  5.0\n  Render lines as tubes:       False\n  Render points as spheres:    False\n  Roughness:                   0.5\n  Show edges:                  False\n  Specular:                    0.0\n  Specular color:              Color(name='red', hex='#ff0000ff', opacity=255)\n  Specular power:              100.0\n  Style:                       "Surface"\n\nDataSetMapper (0x17c8139a020)\n  Scalar visibility:           False\n  Scalar range:                (0.0, 1.0)\n  Interpolate before mapping:  True\n  Scalar map mode:             default\n  Color mode:                  direct\n\nAttached dataset:\nPolyData (0x17c8139bf40)\n  N Cells:    96\n  N Points:   50\n  N Strips:   0\n  X Bounds:   3.097e-02, 3.487e-02\n  Y Bounds:   9.703e-02, 1.009e-01\n  Z Bounds:   7.784e-02, 8.184e-02\n  N Arrays:   1, '1-points': Actor (0x17cd9b00a00)\n  Center:                     (0.032922741025686264, 0.09897983074188232, 0.08504329760074615)\n  Pickable:                   False\n  Position:                   (0.0, 0.0, 0.0)\n  Scale:                      (1.0, 1.0, 1.0)\n  Visible:                    True\n  X Bounds                    3.292E-02, 3.292E-02\n  Y Bounds                    9.898E-02, 9.898E-02\n  Z Bounds                    8.504E-02, 8.504E-02\n  User matrix:                Identity\n  Has mapper:                 True\n\nProperty (0x17c8139a020)\n  Ambient:                     0.0\n  Ambient color:               Color(name='lightblue', hex='#add8e6ff', opacity=255)\n  Anisotropy:                  0.0\n  Color:                       Color(name='lightblue', hex='#add8e6ff', opacity=255)\n  Culling:                     "none"\n  Diffuse:                     1.0\n  Diffuse color:               Color(name='lightblue', hex='#add8e6ff', opacity=255)\n  Edge color:                  Color(name='black', hex='#000000ff', opacity=255)\n  Edge opacity:                1.0\n  Interpolation:               0\n  Lighting:                    True\n  Line width:                  1.0\n  Metallic:                    0.0\n  Opacity:                     1.0\n  Point size:                  0.00279999990016222\n  Render lines as tubes:       False\n  Render points as spheres:    False\n  Roughness:                   0.5\n  Show edges:                  False\n  Specular:                    0.0\n  Specular color:              Color(name='lightblue', hex='#add8e6ff', opacity=255)\n  Specular power:              100.0\n  Style:                       "Surface"\n\nDataSetMapper (0x17c8139a020)\n  Scalar visibility:           False\n  Sca

Check failure on line 1 in test_plot_alignment_hpi_colors_and_labels[pyvistaqt]

See this annotation in the file changed.

@azure-pipelines azure-pipelines / mne-tools.mne-python

test_plot_alignment_hpi_colors_and_labels[pyvistaqt] 

assert 16 == 12
 +  where 16 = len({'PolyData(Addr=000001AB9DC1F1C0)': Actor (0x1abc85e3400)\n  Center:                     (0.03292274009436369, 0.09897983074188232, 0.07984329760074615)\n  Pickable:                   True\n  Position:                   (0.0, 0.0, 0.0)\n  Scale:                      (1.0, 1.0, 1.0)\n  Visible:                    False\n  X Bounds                    3.097E-02, 3.487E-02\n  Y Bounds                    9.703E-02, 1.009E-01\n  Z Bounds                    7.784E-02, 8.184E-02\n  User matrix:                Identity\n  Has mapper:                 True\n\nProperty (0x1abaddf56c0)\n  Ambient:                     0.0\n  Ambient color:               Color(name='red', hex='#ff0000ff', opacity=255)\n  Anisotropy:                  0.0\n  Color:                       Color(name='red', hex='#ff0000ff', opacity=255)\n  Culling:                     "back"\n  Diffuse:                     1.0\n  Diffuse color:               Color(name='red', hex='#ff0000ff', opacity=255)\n  Edge color:                  Color(name='black', hex='#000000ff', opacity=255)\n  Edge opacity:                1.0\n  Interpolation:               InterpolationType.PHONG\n  Lighting:                    True\n  Line width:                  1.0\n  Metallic:                    0.0\n  Opacity:                     0.5\n  Point size:                  5.0\n  Render lines as tubes:       False\n  Render points as spheres:    False\n  Roughness:                   0.5\n  Show edges:                  False\n  Specular:                    0.0\n  Specular color:              Color(name='red', hex='#ff0000ff', opacity=255)\n  Specular power:              100.0\n  Style:                       "Surface"\n\nDataSetMapper (0x1abaddf56c0)\n  Scalar visibility:           False\n  Scalar range:                (0.0, 1.0)\n  Interpolate before mapping:  True\n  Scalar map mode:             default\n  Color mode:                  direct\n\nAttached dataset:\nPolyData (0x1abb87d1780)\n  N Cells:    96\n  N Points:   50\n  N Strips:   0\n  X Bounds:   3.097e-02, 3.487e-02\n  Y Bounds:   9.703e-02, 1.009e-01\n  Z Bounds:   7.784e-02, 8.184e-02\n  N Arrays:   1, '1-points': Actor (0x1abc85e1c00)\n  Center:                     (0.032922741025686264, 0.09897983074188232, 0.08504329760074615)\n  Pickable:                   False\n  Position:                   (0.0, 0.0, 0.0)\n  Scale:                      (1.0, 1.0, 1.0)\n  Visible:                    True\n  X Bounds                    3.292E-02, 3.292E-02\n  Y Bounds                    9.898E-02, 9.898E-02\n  Z Bounds                    8.504E-02, 8.504E-02\n  User matrix:                Identity\n  Has mapper:                 True\n\nProperty (0x1abb87d0760)\n  Ambient:                     0.0\n  Ambient color:               Color(name='lightblue', hex='#add8e6ff', opacity=255)\n  Anisotropy:                  0.0\n  Color:                       Color(name='lightblue', hex='#add8e6ff', opacity=255)\n  Culling:                     "none"\n  Diffuse:                     1.0\n  Diffuse color:               Color(name='lightblue', hex='#add8e6ff', opacity=255)\n  Edge color:                  Color(name='black', hex='#000000ff', opacity=255)\n  Edge opacity:                1.0\n  Interpolation:               InterpolationType.FLAT\n  Lighting:                    True\n  Line width:                  1.0\n  Metallic:                    0.0\n  Opacity:                     1.0\n  Point size:                  0.00279999990016222\n  Render lines as tubes:       False\n  Render points as spheres:    False\n  Roughness:                   0.5\n  Show edges:                  False\n  Specular:                    0.0\n  Specular color:              Color(name='lightblue', hex='#add8e6ff', opacity=255)\n  Specular power:              100.0\n  Style:                       "Surface"\n\nDataSetMapper (0x1abb87d0760)\n  Scalar visibility:           False\n  Scalar range:                (0.0, 1.0)\n  Interpolate before mapping:  True\n  Sca
Raw output 
mne\viz\tests\test_3d.py:938: in test_plot_alignment_hpi_colors_and_labels
    _assert_n_actors(fig, renderer, 12)
E   assert 16 == 12
E    +  where 16 = len({'PolyData(Addr=000001AB9DC1F1C0)': Actor (0x1abc85e3400)\n  Center:                     (0.03292274009436369, 0.09897983074188232, 0.07984329760074615)\n  Pickable:                   True\n  Position:                   (0.0, 0.0, 0.0)\n  Scale:                      (1.0, 1.0, 1.0)\n  Visible:                    False\n  X Bounds                    3.097E-02, 3.487E-02\n  Y Bounds                    9.703E-02, 1.009E-01\n  Z Bounds                    7.784E-02, 8.184E-02\n  User matrix:                Identity\n  Has mapper:                 True\n\nProperty (0x1abaddf56c0)\n  Ambient:                     0.0\n  Ambient color:               Color(name='red', hex='#ff0000ff', opacity=255)\n  Anisotropy:                  0.0\n  Color:                       Color(name='red', hex='#ff0000ff', opacity=255)\n  Culling:                     "back"\n  Diffuse:                     1.0\n  Diffuse color:               Color(name='red', hex='#ff0000ff', opacity=255)\n  Edge color:                  Color(name='black', hex='#000000ff', opacity=255)\n  Edge opacity:                1.0\n  Interpolation:               InterpolationType.PHONG\n  Lighting:                    True\n  Line width:                  1.0\n  Metallic:                    0.0\n  Opacity:                     0.5\n  Point size:                  5.0\n  Render lines as tubes:       False\n  Render points as spheres:    False\n  Roughness:                   0.5\n  Show edges:                  False\n  Specular:                    0.0\n  Specular color:              Color(name='red', hex='#ff0000ff', opacity=255)\n  Specular power:              100.0\n  Style:                       "Surface"\n\nDataSetMapper (0x1abaddf56c0)\n  Scalar visibility:           False\n  Scalar range:                (0.0, 1.0)\n  Interpolate before mapping:  True\n  Scalar map mode:             default\n  Color mode:                  direct\n\nAttached dataset:\nPolyData (0x1abb87d1780)\n  N Cells:    96\n  N Points:   50\n  N Strips:   0\n  X Bounds:   3.097e-02, 3.487e-02\n  Y Bounds:   9.703e-02, 1.009e-01\n  Z Bounds:   7.784e-02, 8.184e-02\n  N Arrays:   1, '1-points': Actor (0x1abc85e1c00)\n  Center:                     (0.032922741025686264, 0.09897983074188232, 0.08504329760074615)\n  Pickable:                   False\n  Position:                   (0.0, 0.0, 0.0)\n  Scale:                      (1.0, 1.0, 1.0)\n  Visible:                    True\n  X Bounds                    3.292E-02, 3.292E-02\n  Y Bounds                    9.898E-02, 9.898E-02\n  Z Bounds                    8.504E-02, 8.504E-02\n  User matrix:                Identity\n  Has mapper:                 True\n\nProperty (0x1abb87d0760)\n  Ambient:                     0.0\n  Ambient color:               Color(name='lightblue', hex='#add8e6ff', opacity=255)\n  Anisotropy:                  0.0\n  Color:                       Color(name='lightblue', hex='#add8e6ff', opacity=255)\n  Culling:                     "none"\n  Diffuse:                     1.0\n  Diffuse color:               Color(name='lightblue', hex='#add8e6ff', opacity=255)\n  Edge color:                  Color(name='black', hex='#000000ff', opacity=255)\n  Edge opacity:                1.0\n  Interpolation:               InterpolationType.FLAT\n  Lighting:                    True\n  Line width:                  1.0\n  Metallic:                    0.0\n  Opacity:                     1.0\n  Point size:                  0.00279999990016222\n  Render lines as tubes:       False\n  Render points as spheres:    False\n  Roughness:                   0.5\n  Show edges:                  False\n  Specular:                    0.0\n  Specular color:              Color(name='lightblue', hex='#add8e6ff', opacity=255)\n  Specular power:              100.0\n  Style:                       "Surface"\n\nDataSetMapper (0x1abb87d0760)\n
View more details on Azure Pipelines