-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
ENH: Add on_drop_all parameter to Epochs.drop #13556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
shruti423
wants to merge
23
commits into
mne-tools:main
Choose a base branch
from
shruti423:warn-epochs-drop
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+50
−1
Open
Changes from 5 commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
484bd9c
ENH: Add on_drop_all parameter to Epochs.drop
shruti423 114fccb
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 4d199d5
TEST : Add test cases for on_drop_all
shruti423 621a2dc
Merge branch 'warn-epochs-drop' of https://github.com/shruti423/mne-p…
shruti423 1c84d61
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 6128160
TEST: Use RandomState and reduce number of epochs
shruti423 6c196c3
Merge fix: Accept RandomState changes and epochs changes
shruti423 79c169f
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] c6ca9cf
Merge branch 'main' into warn-epochs-drop
larsoner ca37daa
DOC: Add changelog entry
shruti423 8d6c0bc
Merge branch 'warn-epochs-drop' of https://github.com/shruti423/mne-p…
shruti423 c01f933
DOC: Fix rst syntax in changelog
shruti423 b100def
Merge branch 'main' into warn-epochs-drop
shruti423 a06aafe
Fix RuntimeError: check len(events) instead of len(self) during drop
shruti423 c708d92
Merge branch 'warn-epochs-drop' of https://github.com/shruti423/mne-p…
shruti423 ebb3272
Merge branch 'main' into warn-epochs-drop
shruti423 d13639a
Merge branch 'main' into warn-epochs-drop
shruti423 65a81cb
Merge branch 'main' into warn-epochs-drop
shruti423 c294520
Trigger CI to retry Windows tests
shruti423 c462435
Merge branch 'warn-epochs-drop' of https://github.com/shruti423/mne-p…
shruti423 8d4bf3f
Fix on_drop_all default to ignore and update docstring
shruti423 235b26e
Update test_drop_all_epochs to match ignore default
shruti423 a3b752b
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use a random state to avoid touching the global seed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also you can use only 1 epoch and not 3. It's a good habit to take to think about keep the test time as low as possible