This MR includes minor changes to eliminate compiler warnings and enhance code robustness.#126
Conversation
We check if the tracking manager is supported (by the utilised Geant4 version) by using a small cxx code when configuring and installing G4HepEm. The G4HepEm_HAS_G4VTRACKINGMANAGER variable is set to True if the code compiles while the G4HepEm_trackingmanager_FOUND variable goes to the G4HepEm config file with a True value. The first is availabel in the same unit, i.e. when building the example application together with G4HepEm e.g. during testing, while only the other is available when using an already installed G4HepEm version. This modification ensures that the application builds as expected in both cases.
…e track leaves the world.
An EM parameter, that corresponds to the G4 LateralDisplacement, has been added to the HepEm parameters. It's initial value is taken from the G4EmParameters at init and controls if lateral displacement is computed in MSC. It allows a bit of optimisation in case of large volumes and used by default in the option2 G4 EM physics constructor (by LHCb). The additional parameter is a tracking cut for gamma which do not exist in G4 in this form. It behaves similarly to the corresponding tracking cut for electron: the gamma tracking is stoped when its energy drops below this energy limit and the current kinetic energy is deposited at that point. This can be achived in several ways inside G4 (e.g. user stepping action or G4UserLimits, etc.). Such a tracking cut is applied by LHCb and this is why it has been introduced now. The default value is zero, i.e. no any tracking cut for gamma by default, that can be changed when constructing the tracking manager.
… is out of the world (killing it as G4).
…ocess pointers, available.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.