Skip to content

Add name to WHEN_TIMEOUT error if available #3599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
evelant wants to merge 2 commits into
base: main
Choose a base branch
from
+1 −1
Open

Add name to WHEN_TIMEOUT error if available #3599

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9c96f91
Add name to WHEN_TIMEOUT error if available
Dec 31, 2022
650166f
Merge remote-tracking branch 'origin/main' into named_when_timeout
kubk Jan 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/mobx/src/api/when.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ export function when(predicate: any, arg1?: any, arg2?: any): any {
function _when(predicate: () => boolean, effect: Lambda, opts: IWhenOptions): IReactionDisposer {
let timeoutHandle: any
if (typeof opts.timeout === "number") {
const error = new Error("WHEN_TIMEOUT")
const error = new Error(`WHEN_TIMEOUT${opts.name ? `: ${opts.name}` : ``}`)
timeoutHandle = setTimeout(() => {
if (!disposer[$mobx].isDisposed_) {
disposer()
Expand Down