Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 0 additions & 19 deletions packages/mobx/__tests__/decorators_20223/stage3-decorators.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1115,22 +1115,3 @@ test(`decorated field can be inherited, but doesn't inherite the effect of decor
const subStore = new SubStore()
expect(isAction(subStore.action)).toBe(false)
})

test(`inheritance should work with computed`, () => {
class Store {
@computed
get getNumber() {
return 1
}
}

class SubStore extends Store {
@computed
override get getNumber() {
return super.getNumber + 1
}
}

const store = new SubStore()
expect(store.getNumber).toBe(2)
})
6 changes: 2 additions & 4 deletions packages/mobx/src/types/computedannotation.ts
Original file line number Diff line number Diff line change
Expand Up @@ -64,13 +64,11 @@ function decorate_20223_(this: Annotation, get, context: ClassGetterDecoratorCon
options.name ||= __DEV__
? `${adm.name_}.${key.toString()}`
: `ObservableObject.${key.toString()}`
const computedValue = new ComputedValue(options)
adm.values_.set(key, computedValue)
adm.values_.set(get, computedValue)
adm.values_.set(key, new ComputedValue(options))
})

return function () {
return this[$mobx].getObservablePropValue_(get)
return this[$mobx].getObservablePropValue_(key)
}
}

Expand Down