Skip to content

fix: Don't rewrap setters on the prototype #4563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mweststrate merged 1 commit into from
Jun 15, 2025
+10 −2
Merged

fix: Don't rewrap setters on the prototype #4563

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fair-houses-rhyme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"mobx": patch
---

Fixed memory leak where makeAutoObservable would keep wrapping setters defined on the prototype. Fixes #4553
7 changes: 5 additions & 2 deletions packages/mobx/src/types/autoannotation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,8 @@ import {
autoAction,
isGenerator,
MakeResult,
die
die,
isAction
} from "../internal"

const AUTO = "true"
Expand Down Expand Up @@ -40,7 +41,9 @@ function make_(
// lone setter -> action setter
if (descriptor.set) {
// TODO make action applicable to setter and delegate to action.make_
const set = createAction(key.toString(), descriptor.set) as (v: any) => void
const set = isAction(descriptor.set)
? descriptor.set // See #4553
: (createAction(key.toString(), descriptor.set) as (v: any) => void)
// own
if (source === adm.target_) {
return adm.defineProperty_(key, {
Expand Down