Skip to content

feat: bump log-symbols from 4 to 7 #5487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JoshuaKGoldberg wants to merge 5 commits into from
+47 −30
Closed

feat: bump log-symbols from 4 to 7 #5487

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
fec8399
feat: bump log-symbols from 4 to 7
JoshuaKGoldberg Oct 2, 2025
e871a1e
fix: switch to the default export
JoshuaKGoldberg Oct 2, 2025
b1dad65
Merge branch 'main'
JoshuaKGoldberg Nov 27, 2025
25973a9
Merge branch 'main' into log-symbols-7
JoshuaKGoldberg Dec 19, 2025
c35501a
Removed unused url code from loader
JoshuaKGoldberg Dec 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/cli/cli.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
*/

const debug = require("debug")("mocha:cli:cli");
const symbols = require("log-symbols");
const { default: symbols } = require("log-symbols");
const yargs = require("yargs");
const path = require("node:path");
const {
Expand Down
2 changes: 1 addition & 1 deletion lib/cli/run.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
* @private
*/

const symbols = require("log-symbols");
const { default: symbols } = require("log-symbols");
const pc = require("picocolors");
const Mocha = require("../mocha");
const {
Expand Down
2 changes: 1 addition & 1 deletion lib/cli/watch-run.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
"use strict";

const logSymbols = require("log-symbols");
const { default: logSymbols } = require('log-symbols');
const debug = require("debug")("mocha:cli:watch");
const path = require("node:path");
const chokidar = require("chokidar");
Expand Down
2 changes: 1 addition & 1 deletion lib/reporters/base.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ var diff = require("diff");
var milliseconds = require("ms");
var utils = require("../utils");
var supportsColor = require("supports-color");
var symbols = require("log-symbols");
var { default: symbols } = require('log-symbols');
var constants = require("../runner").constants;
var EVENT_TEST_PASS = constants.EVENT_TEST_PASS;
var EVENT_TEST_FAIL = constants.EVENT_TEST_FAIL;
Expand Down
61 changes: 42 additions & 19 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@
"he": "^1.2.0",
"is-path-inside": "^3.0.3",
"js-yaml": "^4.1.0",
"log-symbols": "^4.1.0",
"log-symbols": "^7.0.1",
"minimatch": "^9.0.5",
"ms": "^2.1.3",
"picocolors": "^1.1.1",
Expand Down
6 changes: 0 additions & 6 deletions test/integration/fixtures/esm/loader-with-module-not-found/loader-that-recognizes-ts.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
import path from 'path'
import {fileURLToPath} from 'url'

/**
* @param {string} specifier
* @param {{
Expand All @@ -11,8 +8,5 @@ import {fileURLToPath} from 'url'
* @returns {Promise<{ url: string }>}
*/
export async function resolve(specifier, context, defaultResolve) {
const extension = path.extname(
fileURLToPath(/**@type {import('url').URL}*/ (new URL(specifier, context.parentURL))),
)
Copy link
Member Author

@JoshuaKGoldberg JoshuaKGoldberg Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code is unused and causes a different error on main vs. this branch. Same with #5482. 🔪

return await defaultResolve(specifier.replace('.ts', '.mjs'), context, defaultResolve)
}
Loading