Skip to content

feat: bump log-symbols from 4 to 7#5487

Closed
JoshuaKGoldberg wants to merge 5 commits intomochajs:mainfrom
JoshuaKGoldberg:log-symbols-7
Closed

feat: bump log-symbols from 4 to 7#5487
JoshuaKGoldberg wants to merge 5 commits intomochajs:mainfrom
JoshuaKGoldberg:log-symbols-7

Conversation

@JoshuaKGoldberg
Copy link
Member

PR Checklist

Overview

Similar to #5484, this increases the lockfile size for local development dependencies. This is log-symbols@2 is still referenced by:

$ npm ls log-symbols@2
mocha@11.7.4 /Users/josh/repos/mocha
└─┬ karma-mocha-reporter@2.2.5
  └── log-symbols@2.2.0

💖

@mark-wiemer
Copy link
Member

expected '(node:2682) ExperimentalWarning: `--experimental-loader` may be removed in the future; instead use `register()`:
--import \'data:text/javascript,import { register } from "node:module"; import { pathToFileURL } from "node:url"; register("./test/integration/fixtures/esm/loader-with-module-not-found/loader-that-recognizes-ts.mjs", pathToFileURL("./"));\'
    at createModuleLoader (node:internal/modules/esm/loader:956:17)
    at Object.getOrInitializeCascadedLoader (node:internal/modules/esm/loader:1000:22)
    at asyncRunEntryPointWithESMLoader (node:internal/modules/run_main:106:65)
    at runEntryPointWithESMLoader (node:internal/modules/run_main:139:19)
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:176:5)
    at node:internal/main/run_main_module:36:49

node:internal/modules/run_main:123
    triggerUncaughtException(
    ^
TypeError [ERR_INVALID_URL_SCHEME]: The URL must be of scheme file
    at fileURLToPath (node:internal/url:1608:11)
    at resolve (file:///home/runner/work/mocha/mocha/test/integration/fixtures/esm/loader-with-module-not-found/loader-that-recognizes-ts.mjs:15:5)
    at nextResolve (node:internal/modules/esm/hooks:748:28)
    at Hooks.resolve (node:internal/modules/esm/hooks:240:30)
    at MessagePort.handleMessage (node:internal/modules/esm/worker:199:24)
    at [nodejs.internal.kHybridDispatch] (node:internal/event_target:827:20)
    at MessagePort.<anonymous> (node:internal/per_context/messageport:23:28) {
  code: \'ERR_INVALID_URL_SCHEME\'
}

Node.js v22.19.0
'
to contain 'ERR_MODULE_NOT_FOUND'

Good luck!

@JoshuaKGoldberg JoshuaKGoldberg mentioned this pull request Oct 6, 2025
5 tasks
@JoshuaKGoldberg
Copy link
Member Author

Note to self: npx mocha test/integration/esm.spec.js does reproduce this locally.

@codecov
Copy link

codecov bot commented Dec 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.66%. Comparing base (410ce0d) to head (c35501a).
⚠️ Report is 43 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5487      +/-   ##
==========================================
+ Coverage   93.52%   93.66%   +0.13%     
==========================================
  Files          57       57              
  Lines        4465     4465              
  Branches      918      918              
==========================================
+ Hits         4176     4182       +6     
+ Misses        289      283       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

export async function resolve(specifier, context, defaultResolve) {
const extension = path.extname(
fileURLToPath(/**@type {import('url').URL}*/ (new URL(specifier, context.parentURL))),
)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code is unused and causes a different error on main vs. this branch. Same with #5482. 🔪

@JoshuaKGoldberg
Copy link
Member Author

I haven't had time for this for a while. Closing this in case someone else wants to try out the changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

📦 Package: Bump log-symbols from 4 to 7

2 participants