feat: bump log-symbols from 4 to 7#5487
Closed
JoshuaKGoldberg wants to merge 5 commits intomochajs:mainfrom
Closed
feat: bump log-symbols from 4 to 7#5487JoshuaKGoldberg wants to merge 5 commits intomochajs:mainfrom
JoshuaKGoldberg wants to merge 5 commits intomochajs:mainfrom
Conversation
Member
Good luck! |
5 tasks
Member
Author
|
Note to self: |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5487 +/- ##
==========================================
+ Coverage 93.52% 93.66% +0.13%
==========================================
Files 57 57
Lines 4465 4465
Branches 918 918
==========================================
+ Hits 4176 4182 +6
+ Misses 289 283 -6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
JoshuaKGoldberg
commented
Dec 19, 2025
| export async function resolve(specifier, context, defaultResolve) { | ||
| const extension = path.extname( | ||
| fileURLToPath(/**@type {import('url').URL}*/ (new URL(specifier, context.parentURL))), | ||
| ) |
Member
Author
There was a problem hiding this comment.
This code is unused and causes a different error on main vs. this branch. Same with #5482. 🔪
Member
Author
|
I haven't had time for this for a while. Closing this in case someone else wants to try out the changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
status: accepting prsOverview
Similar to #5484, this increases the lockfile size for local development dependencies. This is
log-symbols@2is still referenced by:karmais tracked in 🛠 Repo: Stop using deprecatedkarmalibrary #5253💖