-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
fix: handle empty null-prototyped objects #5506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
JoshuaKGoldberg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - a nice clean fix with a clean unit test. Thanks!
Will leave open a bit in case another maintainer wants to take look too.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5506 +/- ##
=======================================
Coverage 93.68% 93.68%
=======================================
Files 57 57
Lines 4384 4385 +1
Branches 846 847 +1
=======================================
+ Hits 4107 4108 +1
Misses 277 277 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@alxndrsn can you look at the EasyCLA check? Also, we've added formatting to repo, would you mind resolving the merge conflicts? |
Signed, twice. I'm not sure it's registering...
Conflicts resolved 👍 |
Closes #5505
PR Checklist
.expectedwithnullprototype throwsTypeError: value.toString is not a function#5505status: accepting prsOverview