Skip to content

fix: handle empty null-prototyped objects #5506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 9, 2025
Merged

fix: handle empty null-prototyped objects #5506

merged 5 commits into from
Nov 9, 2025

Conversation

@alxndrsn
Copy link
Contributor

@alxndrsn alxndrsn commented Oct 21, 2025 •
edited by JoshuaKGoldberg
Loading

Closes #5505

PR Checklist

Overview

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 21, 2025 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: mark-wiemer / name: Mark Wiemer (322f2ac)

@alxndrsn alxndrsn marked this pull request as ready for review October 21, 2025 18:30
@JoshuaKGoldberg JoshuaKGoldberg mentioned this pull request Oct 22, 2025
Closed
4 tasks
JoshuaKGoldberg
JoshuaKGoldberg approved these changes Oct 22, 2025
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - a nice clean fix with a clean unit test. Thanks!

Will leave open a bit in case another maintainer wants to take look too.

@codecov
Copy link

codecov bot commented Oct 22, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.69%. Comparing base (fb0215b) to head (322f2ac).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #5506   +/-   ##
=======================================
  Coverage   93.69%   93.69%           
=======================================
  Files          57       57           
  Lines        4390     4391    +1     
  Branches      849      850    +1     
=======================================
+ Hits         4113     4114    +1     
  Misses        277      277

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mark-wiemer
Copy link
Member

mark-wiemer commented Nov 1, 2025

@alxndrsn can you look at the EasyCLA check? Also, we've added formatting to repo, would you mind resolving the merge conflicts?

@mark-wiemer mark-wiemer added the status: waiting for author waiting on response from OP or other posters - more information needed label Nov 1, 2025
@alxndrsn
Copy link
Contributor Author

alxndrsn commented Nov 4, 2025

@alxndrsn can you look at the EasyCLA check?

Signed, twice. I'm not sure it's registering...

Also, we've added formatting to repo, would you mind resolving the merge conflicts?

Conflicts resolved 👍

@mark-wiemer
Copy link
Member

mark-wiemer commented Nov 8, 2025 •
edited
Loading

Don't worry about the CLA for this one, your comment here is sufficient and I've opened a support ticket with the EasyCLA team :) @JoshuaKGoldberg, I'm good to merge this one if you are

@mark-wiemer mark-wiemer removed the status: waiting for author waiting on response from OP or other posters - more information needed label Nov 8, 2025
@mark-wiemer
Copy link
Member

mark-wiemer commented Nov 9, 2025

CLA check passed :) going to merge this one once the basic tests pass too

@mark-wiemer mark-wiemer merged commit 2a0bce0 into mochajs:main Nov 9, 2025
80 checks passed
@github-actions github-actions bot mentioned this pull request Nov 8, 2025
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

@mark-wiemer mark-wiemer mark-wiemer approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

🐛 Bug: thrown error .expected with null prototype throws TypeError: value.toString is not a function

3 participants

@alxndrsn @mark-wiemer @JoshuaKGoldberg