Use picocolors instead of supports-color#5509
Conversation
|
I already have a PR for this (though I forgot to remove the browser shim from package.json). It's blocked on alexeyraspopov/picocolors#96, which is causing some tests to fail.
I noticed this is in your PR summary but not in the code changes itself. That's good because it's not necessary: if a dependency itself depends on a package, it'll get installed anyway--that's how package managers work. Why is this line in the PR summary? |
Oh you're right. My mistake. That line is totally unnecessary. Feel free to close this pr if it is a duplicate. |
|
Thanks for trying this out either way! |
PR Checklist
supports-colornow that we have picocolors #5470status: accepting prsOverview
Summary
Removes the supports-color dependency in favor of using picocolors' built-in isColorSupported property, which provides the same functionality.
Changes
Motivation
This change reduces unnecessary dependencies by leveraging functionality already available in picocolors, which Mocha already depends on. The isColorSupported property from picocolors provides the
same color detection capability as supports-color, making the separate dependency redundant.
Fixes #5470