fix: allow chain call timeout to override nested items timeout #5612
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed in chain call Signed-off-by: hainenber <[email protected]>
Signed-off-by: hainenber <[email protected]>
Signed-off-by: hainenber <[email protected]>
…ted-items-timeout
hainenber
changed the title
This reverts commit 18a70c9.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5612 +/- ##
==========================================
+ Coverage 88.40% 88.45% +0.05%
==========================================
Files 66 66
Lines 4787 4791 +4
Branches 977 977
==========================================
+ Hits 4232 4238 +6
+ Misses 555 553 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mark-wiemer
previously requested changes
Jan 4, 2026
mark-wiemer
added
the
status: waiting for author
Co-authored-by: Mark Wiemer <[email protected]>
Signed-off-by: hainenber <[email protected]>
…clearer Signed-off-by: hainenber <[email protected]>
mark-wiemer
removed
the
status: waiting for author
…ted-items-timeout
mark-wiemer
added
the
status: needs review
…ted-items-timeout
…ted-items-timeout
mark-wiemer
removed
the
status: needs review
Signed-off-by: hainenber <[email protected]>
mark-wiemer
approved these changes
Jan 16, 2026
Member
mark-wiemer
left a comment
mark-wiemer
left a comment
There was a problem hiding this comment.
Thank you! I'll give this a few business days for @JoshuaKGoldberg to review :)
JoshuaKGoldberg
approved these changes
Jan 21, 2026
Member
JoshuaKGoldberg
left a comment
JoshuaKGoldberg
left a comment
There was a problem hiding this comment.
I have to admit, I was surprised this solution worked. But it does make sense 🙂 nicely done!
Co-authored-by: Josh Goldberg ✨ <[email protected]>
…ted-items-timeout
lennonnikolas
pushed a commit
to lennonnikolas/mocha
that referenced
this pull request
Jan 24, 2026
…js#5612) Co-authored-by: Mark Wiemer <[email protected]> Co-authored-by: Josh Goldberg ✨ <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
describenot working as expected #5422status: accepting prsOverview
Fixes the issue with
timeoutchain call indescribesuite doesn't correctly override the config for inner/nested suite and test cases.