Skip to content

Comments

fix(deps): update find-up to v8 with API migration#5756

Closed
Copilot wants to merge 4 commits intomainfrom
copilot/sub-pr-5747
Closed

fix(deps): update find-up to v8 with API migration#5756
Copilot wants to merge 4 commits intomainfrom
copilot/sub-pr-5747

Conversation

Copy link
Contributor

Copilot AI commented Feb 21, 2026

  • Identify issues: find-up v8 changed API from findUp.sync() to named export findUpSync()
  • Update lib/cli/config.js to use new findUpSync API
  • Update lib/cli/options.js to use new findUpSync API
  • Update test/node-unit/cli/options.spec.js mock to use { findUpSync: ... } instead of { sync: ... }
  • Update test/node-unit/cli/config.spec.js mock and assertions to use findUpSync
  • Regenerate package-lock.json with npm 10
  • Fix format:check CI failure: updated .github/workflows/mocha.yml to match main branch (paths-ignore entries and PR types filter) and run prettier to format properly
  • Validated: 1100 unit tests passing, smoke tests passing, format:check passing, TypeScript checks passing

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI self-assigned this Feb 21, 2026
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Feb 21, 2026

CLA Not Signed

…package-lock.json with npm 10

Co-authored-by: mark-wiemer <7833360+mark-wiemer@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix dependency: update find-up to version 8 fix(deps): update find-up to v8 with API migration Feb 21, 2026
Copilot AI requested a review from mark-wiemer February 21, 2026 03:28
@mark-wiemer mark-wiemer changed the base branch from renovate/find-up-8.x to main February 21, 2026 03:57
@codecov
Copy link

codecov bot commented Feb 21, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.84%. Comparing base (6cb2710) to head (6261357).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5756      +/-   ##
==========================================
- Coverage   88.85%   88.84%   -0.01%     
==========================================
  Files          66       66              
  Lines        4774     4771       -3     
  Branches      976      976              
==========================================
- Hits         4242     4239       -3     
  Misses        532      532              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mark-wiemer
Copy link
Member

@copilot format:check is failing, please use npm 10 and run all checks just like mocha.yml does in GitHub Actions

…lure

Co-authored-by: mark-wiemer <7833360+mark-wiemer@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Feb 21, 2026

@copilot format:check is failing, please use npm 10 and run all checks just like mocha.yml does in GitHub Actions

Fixed in commit 4d3d81c. The CI format:check was failing because the .github/workflows/mocha.yml in this branch was outdated compared to main (missing additional paths-ignore entries and pull_request.types). When CI created a merge commit, the longer paths-ignore list from main needed prettier's multi-line formatting. Updated mocha.yml to match the current main branch version and ran prettier to format it correctly.

All CI checks now pass locally with npm 10: format:check, tsc, test-smoke, and test-node:unit (1100 passing).

@mark-wiemer
Copy link
Member

closing, gonna do these manually one at a time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants