Open
Conversation
DRVeyl
force-pushed
the
DisconnectedPartitions
branch
from
2d549d5 to
a8a7ae4
Compare
eggrobin
reviewed
Mar 11, 2026
Member
There was a problem hiding this comment.
Can we add a test where we have multiple parts, and test that the partitioner has correctly discovered them?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partition the network once/iteration.
Optimize searches by fast-failing unreachable [src,dest] pairs. That is, pairs where src and dest are in different network partitions.