Skip to content

Conversation

@davemollen
Copy link
Contributor

@davemollen davemollen commented Dec 31, 2024

I expect Rust will need to be updated (rustup update) on the builder to get this PR build to work. Because on the Cloud builder I get lock file version 4 was found, but this version of Cargo does not understand this lock file, perhaps Cargo needs to be updated?.

All my plugins can be built on macOS now too. So these could technically be ported to Mod Desktop now.
I have an example of how I got a macOS desktop build working here: https://github.com/davemollen/dm-SpaceEcho/blob/feature/mod-desktop-build/scripts/build-lv2-for-mod-desktop-mac.sh.

Changes are:

  • dm-Stutter: new Mix parameter
  • dm-Stutter: all note length sliders at 0% gives an even note length distribution
  • dm-GrainDelay: Drift parameter works properly now
  • dm-GrainDelay: bugfix for no sound with Pitch at 0st and Drift at >0%
  • dm-Vibrato: updated default values
  • Param smoothing implementation was updated for all plugins.

@falkTX
Copy link
Member

falkTX commented Jan 6, 2025

very nice, will merge and push to the store.

at what point is the nightly requirement possible to drop?

also, if you see some plugins that you are not thinking of changing (except bugfixes) maybe we can push some to stable?

@falkTX falkTX merged commit cd4b5ec into mod-audio:master Jan 6, 2025
108 checks passed
@falkTX
Copy link
Member

falkTX commented Jan 6, 2025

FYI they are all updated now!

@davemollen
Copy link
Contributor Author

davemollen commented Jan 6, 2025

Thanks! The nightly version is needed for portable_simd to work in Rust, which enables an easy way to implement simd. It's been taking a while already for that feature to reach a stable version. I'm not sure how much longer it will take.

I don't want to change any of these plugins anymore. Expect for the Stutter one, because I might get some user feedback on that one still. And I was considering one slight parameter range change for the SpaceEcho. Are there things to take into account when plugins are released to stable? Are there certain things that can't be changed anymore? Like such a parameter change.

@falkTX
Copy link
Member

falkTX commented Jan 6, 2025

Are there things to take into account when plugins are released to stable? Are there certain things that can't be changed anymore? Like such a parameter change.

the main thing to consider is backwards compatibility, so removing a parameter is out of question. increasing the range of a parameter is okay-ish, pedalboards save the real value so it gets loaded correctly, reducing range is not so good or say changing the parameter type.

it is pretty much common sense things.

if/when a big breakage is needed it is best to do a whole new plugin altogether and mark the old one as legacy.

@davemollen
Copy link
Contributor Author

I was expecting something along these lines. Thanks for clarifying.

@davemollen
Copy link
Contributor Author

davemollen commented Jan 16, 2025

@falkTX All these plugins can be pushed to stable. They're all in a finished state now, since this PR.
I'm not planning on any more changes except bug fixes.

@davemollen
Copy link
Contributor Author

@falkTX Just a reminder in case you've missed the previous message. I checked all plugins that are in beta. They're in a finished state and can be pushed to stable!

@falkTX
Copy link
Member

falkTX commented Feb 20, 2025

sorry for late reply, was waiting until the day I do some hours for MOD.

I can push these plugins to stable yes, I dont like the situation with the nightly toolchain but understand SIMD is tricky to get right and will take some time.
There is no point on holding these, I will trigger stable builds now!

@davemollen
Copy link
Contributor Author

Awesome, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants