-
Notifications
You must be signed in to change notification settings - Fork 56
Update dm plugins #191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dm plugins #191
Conversation
|
very nice, will merge and push to the store. at what point is the nightly requirement possible to drop? also, if you see some plugins that you are not thinking of changing (except bugfixes) maybe we can push some to stable? |
|
FYI they are all updated now! |
|
Thanks! The nightly version is needed for I don't want to change any of these plugins anymore. Expect for the Stutter one, because I might get some user feedback on that one still. And I was considering one slight parameter range change for the SpaceEcho. Are there things to take into account when plugins are released to stable? Are there certain things that can't be changed anymore? Like such a parameter change. |
the main thing to consider is backwards compatibility, so removing a parameter is out of question. increasing the range of a parameter is okay-ish, pedalboards save the real value so it gets loaded correctly, reducing range is not so good or say changing the parameter type. it is pretty much common sense things. if/when a big breakage is needed it is best to do a whole new plugin altogether and mark the old one as legacy. |
|
I was expecting something along these lines. Thanks for clarifying. |
|
@falkTX All these plugins can be pushed to stable. They're all in a finished state now, since this PR. |
|
@falkTX Just a reminder in case you've missed the previous message. I checked all plugins that are in beta. They're in a finished state and can be pushed to stable! |
|
sorry for late reply, was waiting until the day I do some hours for MOD. I can push these plugins to stable yes, I dont like the situation with the nightly toolchain but understand SIMD is tricky to get right and will take some time. |
|
Awesome, thanks! |
I expect Rust will need to be updated (
rustup update) on the builder to get this PR build to work. Because on the Cloud builder I getlock file version4was found, but this version of Cargo does not understand this lock file, perhaps Cargo needs to be updated?.All my plugins can be built on macOS now too. So these could technically be ported to Mod Desktop now.
I have an example of how I got a macOS desktop build working here: https://github.com/davemollen/dm-SpaceEcho/blob/feature/mod-desktop-build/scripts/build-lv2-for-mod-desktop-mac.sh.
Changes are: