Conversation
Contributor
Author
|
@prbot approve |
![modal-pr-review-automation[bot]](https://avatars.githubusercontent.com/in/335990?s=60&v=4){kind=small}
Contributor
|
lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Unskips and activates sandbox image-mount tests for empty mounts, mounting snapshots/images across sandboxes, and error handling for unbuilt images.
modal-js/test/sandbox_mount_image.test.ts:SandboxMountDirectoryEmpty: mount empty directory and verify it exists.SandboxMountDirectoryWithImage: snapshot filesystem from one sandbox and mount in another; verify file contents.SandboxSnapshotDirectory: snapshot a mounted directory and remount; verify file contents.SandboxMountDirectoryWithUnbuiltImageThrows: assert mounting an unbuilt image rejects with expected error.Written by Cursor Bugbot for commit 3ac14c7. This will update automatically on new commits. Configure here.