Add sb.terminate({ wait: true }) parameter to JS#277
Merged
thomasjpfan merged 1 commit intoehdr/dir-snapshots-non-expfrom Feb 19, 2026
Merged
Add sb.terminate({ wait: true }) parameter to JS#277thomasjpfan merged 1 commit intoehdr/dir-snapshots-non-expfrom
thomasjpfan merged 1 commit intoehdr/dir-snapshots-non-expfrom
Conversation
PR SummaryLow Risk Overview Exports the new type from Written by Cursor Bugbot for commit 5ae8aac. This will update automatically on new commits. Configure here. |
thomasjpfan
approved these changes
Feb 19, 2026
thomasjpfan
added a commit
that referenced
this pull request
Feb 20, 2026
) * Only image mount * Less changes * Introduce detach back * Make sure terminate actually calls terminate * Remove the need for ALPN workaround * Add docs * Fix lint * Simplify tls implemetnation * Give terminate error a higher priority * Make diff smaller * Less diff * Ensure that sandbox is attached before running any operation * Less diff * Remove ts detach * Allow for terminate to happen * Use two mutexes * Use atomic bool * Remove profile.TaskCommandRouterInsecure * Terminate no longer detaches * Add detach everywhere * Update examples * Add changelog * Add example to readme * Add ensureAttached to be extra safe * Use a better error message * Add detach and params to Sandbox.Terminate * Update changelog * Fix linter * Do not detach * Add terminate back in * Switch order * Allow for double terminate * Revert "Allow for double terminate" This reverts commit 0a12fb8. * Make more things private * Add Detach semantics everywhere * Fix test and go lint * Revert "Fix test and go lint" This reverts commit 71d3723. * Revert "Add Detach semantics everywhere" This reverts commit c73180a. * Do simple detach * Use postiive phrasing * Fix bug * Simplify detach * Fix compareandswap bug * Use ClientClosedError * Remove js * Add unit test * Fix grammar * Fix race in task command router init * Test refreshJwt recovery on error * Fix refreshJwt retries * Add Sandbox.detach in JS * Handle init race * Mark detached after TCR is closed * Invert the logic and track attached, not detached * Prevent race * Fix elint ignore * Align ClientClosedError behavior in JS with Go * Detach when terminating Sandboxes in JS * JS formatting * Fix tests * Graduate mountImage and snapshotDirectory from experimental status * JS formatting * Add sb.terminate({ wait: true }) parameter to JS (#277) * Fix merge issue * Add more docs * Remove comment * Fix lint --------- Co-authored-by: Thomas J. Fan <thomas@modal.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.