Test support and fix some cross-language behavior deviations#33
Merged
Test support and fix some cross-language behavior deviations#33
Conversation
billyb2
pushed a commit
to depot/libmodal
that referenced
this pull request
Jul 16, 2025
…abs#33) * Test support and fix some cross-language behavior deviations * Fix setup.sh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes two changes:
test-support/setup.shthat creates the test support fixtures programmatically and in the current environment. This scripts the process of creating test supports so they don't reference secrets in a specific environment that could be lost, allowing us to run tests against e.g., dev-clustser, and also documents them. Likewise, removing tests that reference specific environments.nilfield in the registry config, which changes the hash of the image.