Skip to content

Test support and fix some cross-language behavior deviations#33

Merged
ekzhang merged 2 commits intomainfrom
ekzhang/test-support
Jun 18, 2025
Merged

Test support and fix some cross-language behavior deviations#33
ekzhang merged 2 commits intomainfrom
ekzhang/test-support

Conversation

@ekzhang
Copy link
Contributor

@ekzhang ekzhang commented Jun 18, 2025

This PR makes two changes:

  1. Adds test-support/setup.sh that creates the test support fixtures programmatically and in the current environment. This scripts the process of creating test supports so they don't reference secrets in a specific environment that could be lost, allowing us to run tests against e.g., dev-clustser, and also documents them. Likewise, removing tests that reference specific environments.
  2. Fixes a slight deviation between image builds in the modal-js and modal-go SDKs, where one used 2024.10 by default, and the other defaulted to empty builder version (2023.10). This caused images to be rebuilt. Also fixed empty protobuf vs nil field in the registry config, which changes the hash of the image.

@ekzhang ekzhang merged commit 385d43e into main Jun 18, 2025
4 checks passed
@ekzhang ekzhang deleted the ekzhang/test-support branch June 18, 2025 16:23
Copy link
Member

@luiscape luiscape left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️

billyb2 pushed a commit to depot/libmodal that referenced this pull request Jul 16, 2025
…abs#33)

* Test support and fix some cross-language behavior deviations

* Fix setup.sh
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants