Merged
Conversation
gleb-modal
force-pushed
the
gleb/fix-negative-ints-and-marks
branch
from
fc03c7b to
016960a
Compare
ekzhang
approved these changes
Jun 18, 2025
modal-js/src/pickle.test.ts
Outdated
| import { expect, test } from "vitest"; | ||
| import { describe, expect, test } from "vitest"; | ||
| import { dumps, loads, type Protocol } from "./pickle"; | ||
| import { Buffer } from "buffer"; |
Contributor
There was a problem hiding this comment.
nit: import from “node:buffer”
billyb2
pushed a commit
to depot/libmodal
that referenced
this pull request
Jul 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We weren't supporting signed ints. Also found that some lists use MARK op