update the vllm oai client script to accept/detect modal environments#1072
Merged
charlesfrye merged 1 commit intomainfrom Feb 11, 2025
Merged
update the vllm oai client script to accept/detect modal environments#1072charlesfrye merged 1 commit intomainfrom
charlesfrye merged 1 commit intomainfrom
Conversation
Collaborator
Author
|
🚀 The docs preview is ready! Check it out here: https://modal-labs-examples--frontend-preview-03c6ec1.modal.run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We construct the web url using information about the vLLM deployment provided by the user or their Modal configuration, but we weren't looking at environments. That lead to a surprising error for @shariqm-modal when his client hit the deployment in the
mainenvironment of themodal-labsworkspace, which had been deployed with proxy authorization.I think there might be a better way to figure out URLs with the
.web_urlattribute ofFunction, but I'm not 100% sure how to handleserve, so pushing this fix instead.