Skip to content

fix custom node#1075

Merged
kning merged 2 commits intomainfrom
kning/fix-comfy-app
Feb 16, 2025
Merged

fix custom node#1075
kning merged 2 commits intomainfrom
kning/fix-comfy-app

Conversation

@kning
Copy link
Copy Markdown
Contributor

@kning kning commented Feb 16, 2025

Changed the node name again 🤷
image

This time using semantic versioning as written about here: Comfy-Org/comfy-cli#236

Type of Change

  • New example
  • Example updates (Bug fixes, new features, etc.)
  • Other (changes to the codebase, but not to examples)

Checklist

  • Example is testable in synthetic monitoring system, or lambda-test: false is added to example frontmatter (---)
    • Example is tested by executing with modal run or an alternative cmd is provided in the example frontmatter (e.g. cmd: ["modal", "deploy"])
    • Example is tested by running with no arguments or the args are provided in the example frontmatter (e.g. args: ["--prompt", "Formula for room temperature superconductor:"]
  • Example is documented with comments throughout, in a Literate Programming style.
  • Example does not require third-party dependencies to be installed locally
  • Example pins its dependencies
    • Example pins container images to a stable tag, not a dynamic tag like latest
    • Example specifies a python_version for the base image, if it is used
    • Example pins all dependencies to at least minor version, ~=x.y.z or ==x.y
    • Example dependencies with version < 1 are pinned to patch version, ==0.y.z

@kning kning requested a review from charlesfrye February 16, 2025 18:29
Copy link
Copy Markdown
Collaborator

@charlesfrye charlesfrye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@charlesfrye
Copy link
Copy Markdown
Collaborator

🚀 The docs preview is ready! Check it out here: https://modal-labs-examples--frontend-preview-2f12b7d.modal.run

@kning kning merged commit 1c72ae8 into main Feb 16, 2025
7 checks passed
@kning kning deleted the kning/fix-comfy-app branch February 16, 2025 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants