Skip to content

updates image build CI#1085

Merged
charlesfrye merged 1 commit intomainfrom
charlesfrye/ignore_cache-image-builds
Mar 3, 2025
Merged

updates image build CI#1085
charlesfrye merged 1 commit intomainfrom
charlesfrye/ignore_cache-image-builds

Conversation

@charlesfrye
Copy link
Copy Markdown
Collaborator

This PR uses the new MODAL_IGNORE_CACHE flag to trigger image builds in CI without invalidating the cache for other applications in the same workspace, which blocked the actual use of the original implementation in #1074. Supercedes #1079.

Type of Change

  • Other (changes to the codebase, but not to examples)

@charlesfrye charlesfrye requested a review from mwaskom March 3, 2025 21:58
@charlesfrye
Copy link
Copy Markdown
Collaborator Author

🚀 The docs preview is ready! Check it out here: https://modal-labs-examples--frontend-preview-ecb27d7.modal.run

@charlesfrye charlesfrye merged commit d2b3bc3 into main Mar 3, 2025
5 of 6 checks passed
@charlesfrye charlesfrye deleted the charlesfrye/ignore_cache-image-builds branch March 3, 2025 22:04
@mwaskom
Copy link
Copy Markdown
Contributor

mwaskom commented Mar 3, 2025

LMK if you encounter any issues with it!

@charlesfrye
Copy link
Copy Markdown
Collaborator Author

Looking good so far!

Also did a quick tire-kick, running an example repeatedly manually (small window in foreground) without the flag while a build with the flag progressed (in the background, literally).

Screen.Recording.2025-03-03.at.1.47.49.PM.mov

@charlesfrye charlesfrye mentioned this pull request Mar 5, 2025
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants