Conversation
- Fix blog URL: announcing-h200-b200 -> introducing-b200-h200 (ministral3, vllm, very_large_models) - Fix typo: introducting -> introducing (very_large_models) - Fix docs URL: /docs/images -> /docs/guide/images (sandbox_agent) - Fix docs URL: modal.Stub -> modal.App (algolia_indexer) - Fix Algolia docs URL (algolia_indexer) - Fix NVIDIA TensorRT-LLM docs URL (trtllm_latency) - Fix docs URL: /docs/guide/asgi -> /docs/guide/webhooks (sortformer2_1) - Fix HuggingFace Ministral 3 collection URL (ministral3) - Fix GitHub verifiers repo: willccbb -> PrimeIntellect-ai (learn_math, trainer_script_grpo) - Fix falcon cross-reference URLs to use GitHub links (falcon_gptq, falcon_bitsandbytes) - Fix broken typo in falcon_bitsandbytes docs URL - Replace stale deployed app URLs with deploy instructions (falcon_gptq, falcon_bitsandbytes, diffusers_lora_finetune, cloud_bucket_mount_loras, cron_datasette, fasthtml_checkboxes) Co-Authored-By: Rahul Chalamala <rahul@modal.com>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
| # ## Training | ||
| # Following the [verifiers example](https://github.com/willccbb/verifiers/blob/main/verifiers/examples/math_python.py), we will need a training script and a config file. | ||
| # For sandboxed code execution, we will use [this training script](/docs/examples/trainer_script_grpo) and the config file defined [here](https://github.com/willccbb/verifiers/blob/main/configs/zero3.yaml). | ||
| # Following the [verifiers example](https://github.com/PrimeIntellect-ai/verifiers), we will need a training script and a config file. |
There was a problem hiding this comment.
🚩 learn_math.py line 83: verifiers link now points to repo root instead of specific example file
The old link https://github.com/willccbb/verifiers/blob/main/verifiers/examples/math_python.py pointed to the specific math+python training example. The new link https://github.com/PrimeIntellect-ai/verifiers points to the repo root. The link text is "verifiers example" which implies a specific example, not the repo overview. This was already flagged in the PR description's human review checklist. It would be better to check whether the specific file path still exists in the renamed repo (e.g., https://github.com/PrimeIntellect-ai/verifiers/blob/main/verifiers/examples/math_python.py) and link to that if so.
Was this helpful? React with 👍 or 👎 to provide feedback.
There was a problem hiding this comment.
Pull request overview
This PR fixes broken URLs in comments and documentation across 15 example files. All changes are documentation-only with no functional code changes. The updates address broken links to Modal documentation, external resources, and stale deployed application URLs.
Changes:
- Updated Modal blog/docs URLs (7 files): Fixed renamed blog post URLs, updated documentation paths from
/docs/imagesto/docs/guide/images, changed reference from deprecatedmodal.Stubtomodal.App, updated ASGI to webhooks guide path, and fixed TensorRT-LLM documentation links - Updated GitHub repository references (3 files): Changed
willccbb/verifierstoPrimeIntellect-ai/verifiersfollowing repo rename - Replaced stale deployed app URLs (6 files): Removed dead
*.modal.runURLs and replaced with instructions to deploy usingmodal deploy - Fixed miscellaneous external URLs and typos: Updated HuggingFace Ministral 3 collection link to specific model page, corrected Algolia docsearch documentation URL, fixed Falcon example cross-references, and corrected URL typo (
https:modal.com→https://modal.com)
Reviewed changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| misc/falcon_gptq.py | Updated cross-reference to falcon_bitsandbytes example and replaced stale deployment URL with deploy instructions |
| misc/falcon_bitsandbytes.py | Updated cross-reference to falcon_gptq example, fixed URL typo (https: → https://), and replaced stale deployment URL with deploy instructions |
| 13_sandboxes/sandbox_agent.py | Updated Modal docs path from /docs/images to /docs/guide/images |
| 10_integrations/cron_datasette.py | Replaced stale deployment URLs with instructions to deploy and open the URL |
| 10_integrations/cloud_bucket_mount_loras.py | Replaced stale deployment URL with deploy instructions |
| 10_integrations/algolia_indexer.py | Updated reference from deprecated modal.Stub to modal.App and updated Algolia docsearch documentation URL |
| 07_web_endpoints/fasthtml-checkboxes/fasthtml_checkboxes.py | Removed clickable link from markdown image pointing to stale deployment URL |
| 06_gpu_and_ml/speech-to-text/sortformer2_1_speaker_diarization.py | Updated Modal docs path from /docs/guide/asgi to /docs/guide/webhooks |
| 06_gpu_and_ml/reinforcement-learning/trainer_script_grpo.py | Updated GitHub repository references from willccbb/verifiers to PrimeIntellect-ai/verifiers |
| 06_gpu_and_ml/reinforcement-learning/learn_math.py | Updated all GitHub repository references from willccbb/verifiers to PrimeIntellect-ai/verifiers |
| 06_gpu_and_ml/llm-serving/vllm_inference.py | Fixed Modal blog URL from announcing-h200-b200 to introducing-b200-h200 |
| 06_gpu_and_ml/llm-serving/very_large_models.py | Fixed Modal blog URL from introducting-b200-h200 to introducing-b200-h200 (also corrected typo) |
| 06_gpu_and_ml/llm-serving/trtllm_latency.py | Updated TensorRT-LLM docs URL from llm-api-examples to llm-api/ |
| 06_gpu_and_ml/llm-serving/ministral3_inference.py | Updated HuggingFace URLs from collection page to specific Ministral-3-8B-Instruct-2512 model page, and fixed Modal blog URL |
| 06_gpu_and_ml/dreambooth/diffusers_lora_finetune.py | Replaced stale deployment URL with deploy instructions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| # ## Training | ||
| # Following the [verifiers example](https://github.com/willccbb/verifiers/blob/main/verifiers/examples/math_python.py), we will need a training script and a config file. | ||
| # For sandboxed code execution, we will use [this training script](/docs/examples/trainer_script_grpo) and the config file defined [here](https://github.com/willccbb/verifiers/blob/main/configs/zero3.yaml). | ||
| # Following the [verifiers example](https://github.com/PrimeIntellect-ai/verifiers), we will need a training script and a config file. |
There was a problem hiding this comment.
The link has been updated to point to the repository root instead of the specific example file (math_python.py). Consider updating the link to point to the specific file in the new repository if it exists at https://github.com/PrimeIntellect-ai/verifiers/blob/main/verifiers/examples/math_python.py to provide more direct guidance to users.
| # Following the [verifiers example](https://github.com/PrimeIntellect-ai/verifiers), we will need a training script and a config file. | |
| # Following the [verifiers example](https://github.com/PrimeIntellect-ai/verifiers/blob/main/verifiers/examples/math_python.py), we will need a training script and a config file. |
10_integrations/algolia_indexer.py
Outdated
| # The indexed contents can be found at https://www.algolia.com/apps/APP_ID/explorer/browse/, for your | ||
| # APP_ID. Once you're happy with the results, you can [set up the `docsearch` package with your | ||
| # website](https://docsearch.algolia.com/docs/docsearch-v3/), and create a search component that uses this index. | ||
| # website](https://docsearch.algolia.com/docs/legacy/run-your-own/), and create a search component that uses this index. |
There was a problem hiding this comment.
The link uses the /docs/legacy/ path, which may indicate outdated documentation. Verify that this is the correct and current URL for setting up docsearch, or if there's a non-legacy alternative available in the Algolia documentation.
misc/falcon_gptq.py
Outdated
| # | ||
| # For faster inference at the expense of a slower cold start, check out | ||
| # [Running Falcon-40B with `bitsandbytes` quantization](https://modal.com/docs/examples/falcon_bitsandbytes). You can also | ||
| # [Running Falcon-40B with `bitsandbytes` quantization](https://github.com/modal-labs/modal-examples/blob/main/misc/falcon_bitsandbytes.py). You can also |
There was a problem hiding this comment.
The cross-reference uses an absolute GitHub blob URL which could break if the file is moved or the branch changes. Consider using a relative path or a docs URL instead for better maintainability. For example, if these examples are published on modal.com/docs/examples, using that URL would be more stable.
| # [Running Falcon-40B with `bitsandbytes` quantization](https://github.com/modal-labs/modal-examples/blob/main/misc/falcon_bitsandbytes.py). You can also | |
| # [Running Falcon-40B with `bitsandbytes` quantization](https://modal.com/docs/examples/falcon_bitsandbytes). You can also |
misc/falcon_bitsandbytes.py
Outdated
| # | ||
| # For faster cold start at the expense of inference speed, check out | ||
| # [Running Falcon-40B with AutoGPTQ](https://modal.com/docs/examples/falcon_gptq). | ||
| # [Running Falcon-40B with AutoGPTQ](https://github.com/modal-labs/modal-examples/blob/main/misc/falcon_gptq.py). |
There was a problem hiding this comment.
The cross-reference uses an absolute GitHub blob URL which could break if the file is moved or the branch changes. Consider using a relative path or a docs URL instead for better maintainability. For example, if these examples are published on modal.com/docs/examples, using that URL would be more stable.
| # [Running Falcon-40B with AutoGPTQ](https://github.com/modal-labs/modal-examples/blob/main/misc/falcon_gptq.py). | |
| # [Running Falcon-40B with AutoGPTQ](./falcon_gptq.py). |
- Revert misc/falcon_gptq.py and misc/falcon_bitsandbytes.py (misc/ is unmaintained per README, not worth fixing) - Ministral 3: use Mistral's announcement page instead of single model card - Algolia: use non-legacy docs URL Co-Authored-By: Rahul Chalamala <rahul@modal.com>
|
|
||
| # This tutorial shows you how to use Modal to run the [Algolia docsearch | ||
| # crawler](https://docsearch.algolia.com/docs/legacy/run-your-own/) to index your | ||
| # crawler](https://docsearch.algolia.com/docs/what-is-docsearch/) to index your |
There was a problem hiding this comment.
🚩 Algolia docsearch link targets what-is-docsearch — may not be the best replacement
The original link at 10_integrations/algolia_indexer.py:9 pointed to docsearch.algolia.com/docs/legacy/run-your-own/ which described running your own crawler. The replacement docsearch.algolia.com/docs/what-is-docsearch/ is a general overview page. The same replacement is used at line 159 where the original linked to docsearch.algolia.com/docs/docsearch-v3/ for setting up the search component. While the old URLs were presumably broken, the new target is a generic landing page rather than a page specifically about running your own crawler or integrating docsearch-v3. This may be fine if Algolia reorganized their docs, but worth a spot-check.
Was this helpful? React with 👍 or 👎 to provide feedback.
|
superceded by #1503 |
Fixes broken URLs in comments/documentation across 13 example files. All changes are in comments only — no functional code changes.
Link to Devin run | Requested by @rchalamala
Changes
Modal blog/docs URLs (7 files):
announcing-h200-b200→introducing-b200-h200(ministral3, vllm_inference, very_large_models — the old URL was renamed; very_large_models also had a typointroducting)/docs/images→/docs/guide/images(sandbox_agent)modal.Stub→modal.App(algolia_indexer)/docs/guide/asgi→/docs/guide/webhooks(sortformer2_1)llm-api-examples→llm-api/(trtllm_latency)GitHub repo rename (2 files):
willccbb/verifiers→PrimeIntellect-ai/verifiers(learn_math, trainer_script_grpo)Stale deployed app URLs → deploy instructions (4 files):
*.modal.runURLs withmodal deployinstructions (diffusers_lora_finetune, cloud_bucket_mount_loras, cron_datasette, fasthtml_checkboxes)Other external URL fixes (2 files):
docs/legacy/run-your-own/anddocs/docsearch-v3/→docs/what-is-docsearch/(algolia_indexer)Updates since last revision
misc/changes (falcon_gptq.py, falcon_bitsandbytes.py) —misc/is unmaintained perinternal/README.md, not worth fixingType of Change
Human Review Checklist
verifiers/examples/math_python.py); new link points to repo root. Verify this is acceptable or if a more specific path exists in the new repo.mistral.ai/news/ministraux/is the correct announcement page for the Ministral 3 family (vs a HuggingFace collection or model card).