Skip to content

http server sticky#1512

Merged
charlesfrye merged 7 commits intomainfrom
charlesfrye/http_server_sticky
Feb 26, 2026
Merged

http server sticky#1512
charlesfrye merged 7 commits intomainfrom
charlesfrye/http_server_sticky

Conversation

@charlesfrye
Copy link
Copy Markdown
Collaborator

@charlesfrye charlesfrye commented Feb 26, 2026

This PR adds an example that demonstrates the sticky routing behavior.

The text includes a link to an http_server example that will appear in a concurrent PR. I won't make this example discoverable on the marketing site until I have that one merged as well.

Type of Change

  • New example for the GitHub repo
    • New example for the documentation site (Linked from a discoverable page, e.g. via the sidebar in /docs/examples)

Monitoring Checklist

  • Example is configured for testing in the synthetic monitoring system, or lambda-test: false is provided in the example frontmatter and I have gotten approval from a maintainer
    • Example is tested by executing with modal run, or an alternative cmd is provided in the example frontmatter (e.g. cmd: ["modal", "serve"])
    • Example is tested by running the cmd with no arguments, or the args are provided in the example frontmatter (e.g. args: ["--prompt", "Formula for room temperature superconductor:"]
    • Example does not require third-party dependencies besides fastapi to be installed locally (e.g. does not import requests or torch in the global scope or other code executed locally)

Documentation Site Checklist

Content

  • Example is documented with comments throughout, in a Literate Programming style
  • All media assets for the example that are rendered in the documentation site page are retrieved from modal-cdn.com

Build Stability

  • Example pins all dependencies in container images
    • Example pins container images to a stable tag like v1, not a dynamic tag like latest
      - [ ] Example specifies a python_version for the base image, if it is used. The demonstrated behavior is so fundamental that IMO we should expect it to work across many Python versions, so I am not pinning here.
    • Example pins all dependencies to at least SemVer minor version, ~=x.y.z or ==x.y, or we expect this example to work across major versions of the dependency and are committed to maintenance across those versions
      • Example dependencies with version < 1 are pinned to patch version, ==0.y.z

Open with Devin

@charlesfrye charlesfrye requested a review from molocule February 26, 2026 22:02
Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 4 additional findings.

Open in Devin Review

@charlesfrye
Copy link
Copy Markdown
Collaborator Author

Sorry for the noise -- ended up with a failure that only happened in CI, probably because they are very smol machines. Could have replicated locally, but was lazy and just pushed repeatedly instead.

I (my coding agent) switched to including timeouts amount the expected errors, and we've now had two successes in a row after three failures in a row. Will review synmon to see if this shows up there, in which case this might need more attention.

@prbot approve

Copy link
Copy Markdown

@modal-pr-review-automation modal-pr-review-automation bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved 👍. @molocule will follow-up review this.

@charlesfrye charlesfrye merged commit 7ebc4f1 into main Feb 26, 2026
6 checks passed
@charlesfrye charlesfrye deleted the charlesfrye/http_server_sticky branch February 26, 2026 23:34
Copy link
Copy Markdown
Contributor

@molocule molocule left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for writing this !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants