Merged
Conversation
Collaborator
Author
|
Sorry for the noise -- ended up with a failure that only happened in CI, probably because they are very smol machines. Could have replicated locally, but was lazy and just pushed repeatedly instead. I (my coding agent) switched to including timeouts amount the expected errors, and we've now had two successes in a row after three failures in a row. Will review synmon to see if this shows up there, in which case this might need more attention. @prbot approve |
molocule
reviewed
Feb 26, 2026
Contributor
molocule
left a comment
There was a problem hiding this comment.
thanks for writing this !!
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds an example that demonstrates the sticky routing behavior.
The text includes a link to an
http_serverexample that will appear in a concurrent PR. I won't make this example discoverable on the marketing site until I have that one merged as well.Type of Change
/docs/examples)Monitoring Checklist
lambda-test: falseis provided in the example frontmatter and I have gotten approval from a maintainermodal run, or an alternativecmdis provided in the example frontmatter (e.g.cmd: ["modal", "serve"])cmdwith no arguments, or theargsare provided in the example frontmatter (e.g.args: ["--prompt", "Formula for room temperature superconductor:"]fastapito be installed locally (e.g. does not importrequestsortorchin the global scope or other code executed locally)Documentation Site Checklist
Content
modal-cdn.comBuild Stability
v1, not a dynamic tag likelatest- [ ] Example specifies a
python_versionfor the base image, if it is used. The demonstrated behavior is so fundamental that IMO we should expect it to work across many Python versions, so I am not pinning here.~=x.y.zor==x.y, or we expect this example to work across major versions of the dependency and are committed to maintenance across those versionsversion < 1are pinned to patch version,==0.y.z