Skip to content

Add Miles LoRA example#65

Merged
jvmncs merged 5 commits intomainfrom
jason/miles-lora
Mar 31, 2026
Merged

Add Miles LoRA example#65
jvmncs merged 5 commits intomainfrom
jason/miles-lora

Conversation

@jvmncs
Copy link
Copy Markdown
Contributor

@jvmncs jvmncs commented Mar 24, 2026

Follows Ray submit job pattern from ray/ example.

Checklist

  • Example is documented with comments throughout, in a Literate Programming style.
  • Example does not require third-party dependencies to be installed locally
  • Example follows the style guide
  • Example pins its dependencies
    • Example pins container images to a stable tag, not a dynamic tag like latest
    • Example specifies a python_version for the base image, if it is used
    • Example pins all dependencies to at least minor version, ~=x.y.z or ==x.y
    • Example dependencies with version < 1 are pinned to patch version, ==0.y.z

(Modal's internal guide page for this repo is Multi-node examples guidance.)

Outside contributors

You're great! Thanks for your contribution.

@jvmncs jvmncs force-pushed the jason/miles-lora branch from 88991cb to 8d9664f Compare March 27, 2026 03:11
@jvmncs jvmncs marked this pull request as ready for review March 31, 2026 17:35
@jvmncs
Copy link
Copy Markdown
Contributor Author

jvmncs commented Mar 31, 2026

@prbot approve @nanjiangwill @pawalt

Copy link
Copy Markdown

@modal-pr-review-automation modal-pr-review-automation bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved 👍. @nanjiangwill will follow-up review this.

@jvmncs jvmncs merged commit 1ee7df7 into main Mar 31, 2026
@jvmncs jvmncs deleted the jason/miles-lora branch March 31, 2026 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants