Add type hints to seq()'s increment_by argument #560
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preamble
The following snippet (adapted from the Recipes docs) results in a pylance error on the non-int
increment_byarguments passed toseq()(the float and timedelta())There seems to be a fair bit of inconsistency between the code and the docs (and other parts of the code) but I'm going with the assumption that the intended behavior is what's been more recently updated. In this case, that is the behavior of
seq(), not its docstring.In other words, the docs and the docstring make it sound like (at least to me) the
valueargument should be null fordatetimetypes, but the function body expects them to be passed to value.Describe the change
Add type hints to seq()'s increment_by argument that align with the function's behavior
PR Checklist