Fix AttributeError on ManyToOneRel fields (#575) #576
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the change
Adds a defensive check to skip
ForeignObjectRelinstances (reverse relations likeManyToOneRel) in_skip_field().These objects don't have
has_default()and other Field attributes, which can causeAttributeErrorin certain model configurations.I could not yet reproduce the issue with test models, this is why tests are a bit convoluted. Will follow up on this one.
PR Checklist
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.