Skip to content

Fix elicitation tests for SDK 1.23.0-beta.0 #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
felixweinberger wants to merge 2 commits into from
+6 −3
Closed

Fix elicitation tests for SDK 1.23.0-beta.0 #50

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f75650f
Fix elicitation tests for SDK 1.23.0-beta.0
felixweinberger Nov 21, 2025
bc47080
Merge branch 'main' into fweinberger/test-ts-sdk-1.23.0-beta.0
felixweinberger Nov 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions examples/servers/typescript/everything-server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -385,6 +385,7 @@ function createMcpServer() {
{
method: 'elicitation/create',
params: {
mode: 'form',
message: args.message,
requestedSchema: {
type: 'object',
Expand Down Expand Up @@ -437,6 +438,7 @@ function createMcpServer() {
{
method: 'elicitation/create',
params: {
mode: 'form',
message: 'Please review and update the form fields with defaults',
requestedSchema: {
type: 'object',
Expand Down Expand Up @@ -512,6 +514,7 @@ function createMcpServer() {
{
method: 'elicitation/create',
params: {
mode: 'form',
message: 'Please select options from the enum fields',
requestedSchema: {
type: 'object',
Expand Down
2 changes: 1 addition & 1 deletion package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@
"vitest": "^4.0.5"
},
"dependencies": {
"@modelcontextprotocol/sdk": "^1.23.0-beta.0",
"@modelcontextprotocol/sdk": "1.23.0-beta.0",
"commander": "^14.0.2",
"express": "^5.1.0",
"zod": "^3.25.76"
Expand Down
2 changes: 1 addition & 1 deletion vitest.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ export default defineConfig({
globals: true,
environment: 'node',
include: ['**/*.test.ts'],
exclude: ['node_modules', 'dist'],
exclude: ['**/node_modules/**', 'dist'],
// Run test files sequentially to avoid port conflicts
fileParallelism: false,
// Increase timeout for server tests in CI
Expand Down
Loading