Add DistributedCacheEventStreamStore
#1136
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scutuatua-crypto
approved these changes
Jan 10, 2026
stephentoub
reviewed
Jan 12, 2026
| <ItemGroup> | ||
| <PackageReference Include="Microsoft.Extensions.AI.Abstractions" /> | ||
| <PackageReference Include="Microsoft.Extensions.Logging.Abstractions" /> | ||
| <PackageReference Include="Microsoft.Extensions.Caching.Abstractions" /> |
Contributor
There was a problem hiding this comment.
Is ModelContextProtocol.Core the right assembly for this, or should it instead live in ModelContextProtocol or ModelContextProtocol.AspNetCore?
Collaborator
Author
There was a problem hiding this comment.
It could probably live in ModelContextProtocol.AspNetCore for the sake of minimizing dependencies in the .Core project.
src/ModelContextProtocol.Core/Server/DistributedCacheEventIdFormatter.cs
Show resolved
Hide resolved
| // Base64-encode session and stream IDs so the event ID can be parsed | ||
| // even if the original IDs contain the ':' separator character | ||
| var sessionBase64 = Convert.ToBase64String(Encoding.UTF8.GetBytes(sessionId)); | ||
| var streamBase64 = Convert.ToBase64String(Encoding.UTF8.GetBytes(streamId)); |
Contributor
There was a problem hiding this comment.
Separate from this PR, we should really add Base64 overloads that handle this without the intermediate byte[]. I will follow up.
src/ModelContextProtocol.Core/Server/DistributedCacheEventStreamStore.cs
Outdated
Show resolved
Hide resolved
MackinnonBuck
force-pushed
the
mbuck/distributed-sse-event-stream-store
branch
from
e01c4f4 to
80b2cb4
Compare
scutuatua-crypto
approved these changes
Jan 16, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening initially as a draft until #1077 gets merged