Extend progress notification support #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

stephentoub merged 2 commits into modelcontextprotocol:main from Tyler-R-Kendrick:progress-tokens

Apr 1, 2025

Contributor

Tyler-R-Kendrick commented Mar 31, 2025

Added implementation of progress notifications for server and client default handlers.
Corrected request type hierarchy to provide "meta" parameters from base request to support progress.
Added IProgress type to sampling handler.

Tyler-R-Kendrick marked this pull request as ready for review

March 31, 2025 17:28

Contributor Author

Tyler-R-Kendrick commented Mar 31, 2025

This is to address the issue I opened:
#111

Contributor

stephentoub commented Mar 31, 2025

Thanks, @Tyler-R-Kendrick. Can you please take a look at the latest in main, and in particular the progress changes that were merged in #145? I expect this PR will need to be changed a bit based on that.

stephentoub reviewed

View reviewed changes

src/ModelContextProtocol/ProgressNotificationValue.cs Outdated Show resolved Hide resolved

stephentoub reviewed

View reviewed changes

src/ModelContextProtocol/Protocol/Types/ProgressNotificationParams.cs Outdated Show resolved Hide resolved

stephentoub reviewed

View reviewed changes

src/ModelContextProtocol/Server/McpServer.cs Outdated Show resolved Hide resolved

stephentoub reviewed

View reviewed changes

src/ModelContextProtocol/Server/McpServer.cs Outdated Show resolved Hide resolved

stephentoub reviewed

View reviewed changes

src/ModelContextProtocol/Server/McpServer.cs Outdated Show resolved Hide resolved

stephentoub reviewed

View reviewed changes

src/ModelContextProtocol/Server/McpServer.cs Outdated Show resolved Hide resolved

stephentoub reviewed

View reviewed changes

src/ModelContextProtocol/Server/McpServer.cs Outdated Show resolved Hide resolved

stephentoub reviewed

View reviewed changes

src/ModelContextProtocol/Server/McpServerExtensions.cs Outdated Show resolved Hide resolved

stephentoub reviewed

View reviewed changes

Contributor

stephentoub left a comment

Thanks for working to improve this area.

stephentoub changed the title ~~Progress-tokens~~ Extend progress notification support

stephentoub reviewed

View reviewed changes

src/ModelContextProtocol/Server/McpServer.cs Outdated Show resolved Hide resolved

stephentoub reviewed

View reviewed changes

src/ModelContextProtocol/Server/McpServer.cs Outdated Show resolved Hide resolved

stephentoub reviewed

View reviewed changes

.devcontainer/devcontainer.json Outdated Show resolved Hide resolved

stephentoub reviewed

View reviewed changes

src/ModelContextProtocol/Client/McpClient.cs Show resolved Hide resolved

stephentoub reviewed

View reviewed changes

src/ModelContextProtocol/Client/McpClient.cs Outdated Show resolved Hide resolved

stephentoub reviewed

View reviewed changes

src/ModelContextProtocol/Client/McpClientExtensions.cs Outdated Show resolved Hide resolved

stephentoub reviewed

View reviewed changes

src/ModelContextProtocol/Client/McpClientExtensions.cs Outdated Show resolved Hide resolved

stephentoub reviewed

View reviewed changes

src/ModelContextProtocol/Client/McpClientExtensions.cs Show resolved Hide resolved

stephentoub reviewed

View reviewed changes

src/ModelContextProtocol/Client/McpClientExtensions.cs Outdated Show resolved Hide resolved

stephentoub reviewed

View reviewed changes

src/ModelContextProtocol/Client/McpClientExtensions.cs Outdated Show resolved Hide resolved

stephentoub reviewed

View reviewed changes

src/ModelContextProtocol/Protocol/Types/ListPromptsRequestParams.cs Show resolved Hide resolved

stephentoub reviewed

View reviewed changes

src/ModelContextProtocol/Server/McpServerExtensions.cs Outdated Show resolved Hide resolved

stephentoub reviewed

View reviewed changes

src/ModelContextProtocol/Server/McpServer.cs Outdated Show resolved Hide resolved

stephentoub reviewed

View reviewed changes

src/ModelContextProtocol/TokenProgress.cs Outdated Show resolved Hide resolved

stephentoub reviewed

View reviewed changes

src/ModelContextProtocol/TokenProgress.cs Outdated Show resolved Hide resolved

stephentoub reviewed

View reviewed changes

src/ModelContextProtocol/Client/McpClient.cs Outdated Show resolved Hide resolved

stephentoub reviewed

View reviewed changes

src/ModelContextProtocol/ClientTokenProgress.cs Outdated Show resolved Hide resolved

stephentoub reviewed

View reviewed changes

src/ModelContextProtocol/Server/McpServer.cs Outdated Show resolved Hide resolved

Contributor

stephentoub commented Apr 1, 2025

Thanks for working on this. I'm going to push a few changes to your branch, if that's ok.

Tyler-R-Kendrick and others added 2 commits

April 1, 2025 09:55


          Extend progress notification support

6aa993d


          Address feedback and fix test

e9faef7

stephentoub force-pushed the progress-tokens branch from bb54fb7 to e9faef7 Compare

April 1, 2025 15:25

stephentoub approved these changes

View reviewed changes

Contributor

stephentoub commented Apr 1, 2025

@Tyler-R-Kendrick, can you please hold off on pushing changes? I was about to merge based on what I'd pushed.

stephentoub force-pushed the progress-tokens branch from 8bb6055 to e9faef7 Compare

April 1, 2025 15:32

stephentoub merged commit 25bcb44 into modelcontextprotocol:main

16 checks passed

This was referenced Jul 24, 2025

Bump Aspire.Hosting.AppHost and 11 others microsoft/Generative-AI-for-beginners-dotnet#205

Closed

Bump Aspire.Hosting.AppHost and 11 others microsoft/Generative-AI-for-beginners-dotnet#212

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet