Trim "title" and "description" keywords from root-level schemas. #436
Conversation
There was a problem hiding this comment.
It does seem like having the "title" and "description" in the auto-generated JSON Schema is unexpected and redundant in the context of MCP. I don't love this way of dealing with it though. Anyone configuring their own SchemaCreateOptions no needs to know to remove the "title" and "description" properties from the root of the schema in a custom transformation to get the better behavior.
I think it would be far better to update AIJsonUtilities.CreateFunctionJsonSchema, AIJsonSchemaCreateOptions and AIFunctionFactory to let you disable top-level "title" and "description" properties in the schema. Why is it possible to override the value of these properties but not remove them without a custom transformation? If we did this, we could then update the default SchemaCreateOptions to be non-null with the MCP-specific configuration that disables the title and description.
| } | ||
|
|
||
| [Fact] | ||
| public void TrimsDescriptionAndTitleKeywordsFromRootSchema() |
There was a problem hiding this comment.
Should we add a similar test for prompts?
It's a good point, I think we might consider eliminating |
|
@halter73 I've opened a second PR in dotnet/extensions#6465 that applies your suggestion. Will keep this one open until we decide which way to go. |
|
Superseded by dotnet/extensions#6465 |
2 participants
Fix #342.