Skip to content

Fix URI template derivation and lookup #530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jun 23, 2025
Merged

Fix URI template derivation and lookup #530

merged 9 commits into from
Jun 23, 2025

Conversation

eiriktsarpalis
Copy link
Member

Makes the following changes:

  • When deriving a resource URI template, converts the host component to lowercase.
  • Defaults the mimetype to "application/octetstream".

This should mitigate some of the issues described in #516.

@eiriktsarpalis eiriktsarpalis linked an issue Jun 18, 2025 that may be closed by this pull request
MCP Resources without parameters don't work without mime-type specified #516
Closed
@eiriktsarpalis eiriktsarpalis mentioned this pull request Jun 18, 2025
Closed
halter73
halter73 reviewed Jun 19, 2025
View reviewed changes
stephentoub
stephentoub reviewed Jun 21, 2025
View reviewed changes
stephentoub
stephentoub reviewed Jun 21, 2025
View reviewed changes
@eiriktsarpalis eiriktsarpalis changed the title Use lowercase host in resource URI template derivation. Fix URI template derivation and lookup Jun 23, 2025
stephentoub
stephentoub reviewed Jun 23, 2025
View reviewed changes
stephentoub
stephentoub reviewed Jun 23, 2025
View reviewed changes
@eiriktsarpalis eiriktsarpalis merged commit 0b26b7b into modelcontextprotocol:main Jun 23, 2025
7 checks passed
@eiriktsarpalis eiriktsarpalis deleted the use-lowercase-derived-uritemplaes branch June 23, 2025 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@halter73 halter73 halter73 left review comments

@stephentoub stephentoub stephentoub approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

MCP Resources without parameters don't work without mime-type specified

3 participants

@eiriktsarpalis @halter73 @stephentoub