-
Notifications
You must be signed in to change notification settings - Fork 546
Fix ResourceLinkBlock deserialization by adding missing "name" case #645
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
d70b7cb
Initial plan
Copilot 66b40d9
Initial analysis and plan for ResourceLinkBlock deserialization fix
Copilot 32bafc2
Fix ResourceLinkBlock deserialization by adding missing "name" case
Copilot c0e2df1
Remove unnecessary dotnet-install.sh file
Copilot e7d06c2
Use const for JSON string variables and improve indentation
Copilot 9fa5eab
Remove temporary backup file
Copilot 369f79a
Change JSON variable names to use PascalCase (Json) as requested
Copilot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
83 changes: 83 additions & 0 deletions
83
tests/ModelContextProtocol.Tests/Protocol/ContentBlockTests.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,83 @@ | ||
| using System.Text.Json; | ||
| using ModelContextProtocol.Protocol; | ||
|
|
||
| namespace ModelContextProtocol.Tests.Protocol; | ||
|
|
||
| public class ContentBlockTests | ||
| { | ||
| [Fact] | ||
| public void ResourceLinkBlock_SerializationRoundTrip_PreservesAllProperties() | ||
| { | ||
| // Arrange | ||
| var original = new ResourceLinkBlock | ||
| { | ||
| Uri = "https://example.com/resource", | ||
| Name = "Test Resource", | ||
| Description = "A test resource for validation", | ||
| MimeType = "text/plain", | ||
| Size = 1024 | ||
| }; | ||
|
|
||
| // Act - Serialize to JSON | ||
| string json = JsonSerializer.Serialize(original, McpJsonUtilities.DefaultOptions); | ||
|
|
||
| // Act - Deserialize back from JSON | ||
| var deserialized = JsonSerializer.Deserialize<ContentBlock>(json, McpJsonUtilities.DefaultOptions); | ||
|
|
||
| // Assert | ||
| Assert.NotNull(deserialized); | ||
| var resourceLink = Assert.IsType<ResourceLinkBlock>(deserialized); | ||
|
|
||
| Assert.Equal(original.Uri, resourceLink.Uri); | ||
| Assert.Equal(original.Name, resourceLink.Name); | ||
| Assert.Equal(original.Description, resourceLink.Description); | ||
| Assert.Equal(original.MimeType, resourceLink.MimeType); | ||
| Assert.Equal(original.Size, resourceLink.Size); | ||
| Assert.Equal("resource_link", resourceLink.Type); | ||
| } | ||
|
|
||
| [Fact] | ||
| public void ResourceLinkBlock_DeserializationWithMinimalProperties_Succeeds() | ||
| { | ||
| // Arrange - JSON with only required properties | ||
| string json = """ | ||
| { | ||
| "type": "resource_link", | ||
| "uri": "https://example.com/minimal", | ||
| "name": "Minimal Resource" | ||
| } | ||
| """; | ||
|
|
||
| // Act | ||
| var deserialized = JsonSerializer.Deserialize<ContentBlock>(json, McpJsonUtilities.DefaultOptions); | ||
|
|
||
| // Assert | ||
| Assert.NotNull(deserialized); | ||
| var resourceLink = Assert.IsType<ResourceLinkBlock>(deserialized); | ||
|
|
||
| Assert.Equal("https://example.com/minimal", resourceLink.Uri); | ||
| Assert.Equal("Minimal Resource", resourceLink.Name); | ||
| Assert.Null(resourceLink.Description); | ||
| Assert.Null(resourceLink.MimeType); | ||
| Assert.Null(resourceLink.Size); | ||
| Assert.Equal("resource_link", resourceLink.Type); | ||
| } | ||
|
|
||
| [Fact] | ||
| public void ResourceLinkBlock_DeserializationWithoutName_ThrowsJsonException() | ||
| { | ||
| // Arrange - JSON missing the required "name" property | ||
| string json = """ | ||
| { | ||
| "type": "resource_link", | ||
| "uri": "https://example.com/missing-name" | ||
| } | ||
| """; | ||
|
|
||
| // Act & Assert | ||
| var exception = Assert.Throws<JsonException>(() => | ||
| JsonSerializer.Deserialize<ContentBlock>(json, McpJsonUtilities.DefaultOptions)); | ||
|
|
||
| Assert.Contains("Name must be provided for 'resource_link' type", exception.Message); | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.