Implement DefaultMcpEndpointRouteBuilderConfigurator for MCP endpoint configuration #691
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
halter73
reviewed
Aug 8, 2025
| ?? throw new InvalidOperationException( | ||
| "You must call WithHttpTransport(). Unable to find required services. Call builder.Services.AddMcpServer().WithHttpTransport() in application startup code." | ||
| ); | ||
| return configurator.Configure(endpoints, pattern); |
There was a problem hiding this comment.
I don't think we should add a hook for a service to replace the implementation of MapMcp() entirely. If you want something that behaves radically differently, you can create your own MapWhateverMcp() method.
There was a problem hiding this comment.
It isn't radically different though, It is nearly exactly the same, minus the stateless behavior. Do we really want to force people to have to learn about MapWhateverMcp calls? I can guarantee you that some people will forget to change to the other MapWhatever call and will file an issue about "MapMcp" isn't working
|
I'm closing this for now. You know how to reach me if you want to discuss or reopen. 😆 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
We need the ability to implement different transports (such as via orleans), without requiring consumers to use methods other than MapMcp.
Breaking Changes
No
Types of changes