Skip to content

Conversation

@stephentoub
Copy link
Contributor

No description provided.

@stephentoub stephentoub requested a review from halter73 March 20, 2025 03:51
@stephentoub stephentoub requested review from eiriktsarpalis and removed request for halter73 March 20, 2025 03:56
<PackageVersion Include="System.Linq.AsyncEnumerable" Version="$(System10Version)" />
<PackageVersion Include="xunit" Version="2.9.2" />
<PackageVersion Include="xunit.runner.visualstudio" Version="3.0.0" />
<PackageVersion Include="xunit.v3" Version="2.0.0" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an unresolved issue with xunit.v3 >= 2.0.0 and Rider. I would recommend using 1.0.x for now until it gets resolved.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<PackageVersion Include="xunit.v3" Version="2.0.0" />
<PackageVersion Include="xunit.v3" Version="1.1.0" />

Copy link
Member

@eiriktsarpalis eiriktsarpalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Would it be possible to apply the newly introduced Assert.Skip in the integration tests lacking an environment? It's the ones where we just return early today.

@eiriktsarpalis eiriktsarpalis merged commit 27ba8b1 into main Mar 20, 2025
6 checks passed
@eiriktsarpalis eiriktsarpalis deleted the xunitv3 branch March 20, 2025 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants