Ochafik/add zip tool #15
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, incl. data URIs) This change ports the ZIP tool from PR #2830 in the modelcontextprotocol/servers repository to the example-remote-server codebase. The zip tool: - Takes a mapping of filenames to URLs (which can be data URIs) - Fetches files from those URLs - Compresses them into a zip archive - Returns the zip as a data URI resource link This demonstrates best practices for handling URIs in MCP tools, including both consuming input URIs and producing output data URIs. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
…rce) This change ports the enhancements from PR #2831 in the modelcontextprotocol/servers repository to the example-remote-server codebase. The zip tool now supports three output formats via the 'outputType' parameter: 1. 'inlinedResourceLink' (default) - Returns a resource_link with a data URI (the original behavior, most efficient for small files) 2. 'resourceLink' - Returns a link to a resource stored in a transient map, allowing clients to read the resource later via ReadResource requests 3. 'resource' - Returns the full resource object directly inline This demonstrates best practices for handling multiple output formats and managing transient resources that can be read after the tool completes. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
domdomegg
reviewed
Oct 10, 2025
| } from "@modelcontextprotocol/sdk/types.js"; | ||
| import { z } from "zod"; | ||
| import { zodToJsonSchema } from "zod-to-json-schema"; | ||
| import JSZip from "jszip"; |
There was a problem hiding this comment.
I think you can do this with node:zlib (https://nodejs.org/api/zlib.html) so you don't need to add another dependency
domdomegg
reviewed
Oct 10, 2025
| return { content }; | ||
| } | ||
|
|
||
| if (name === ToolName.ZIP_RESOURCES) { |
There was a problem hiding this comment.
for later: at some point we should migrate this whole server to the newer nicer API
There was a problem hiding this comment.
i.e. server.registerTool, rather than server.setRequestHandler(CallToolRequestSchema, ...)
domdomegg
reviewed
Oct 10, 2025
|
|
||
| for (const [fileName, fileUrl] of Object.entries(files)) { | ||
| try { | ||
| const response = await fetch(fileUrl); |
There was a problem hiding this comment.
I think we might want to screen this to avoid SSRF attacks.
domdomegg
reviewed
Oct 10, 2025
|
|
||
| for (const [fileName, fileUrl] of Object.entries(files)) { | ||
| try { | ||
| const response = await fetch(fileUrl); |
There was a problem hiding this comment.
I think we want to be careful handling the result / set some limit to avoid DoS attacks. E.g. getting us to download a 2GB file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Porting over zip tool from everything-server: shows how to accept binary inputs (as uri strings) and produce binary outputs (resources or resource links)
cc/ crondinini-ant@