mcp: negotiate protocol version #112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Negotiate the protocol version properly, and set the header on HTTP transports. We follow the logic of the Typescript SDK. - On initialization, the client sends the latest version it can support, and accepts the version that the server returns if the client supports it. If not, the connection fails. - The server accepts the client's version unless it doesn't support it, in which case it replies with its latest version.
samthanawalla
previously approved these changes
Jul 9, 2025
findleyr
previously approved these changes
Jul 10, 2025
mcp/shared.go
Outdated
| // It is the version that the client sends in the initialization request. | ||
| const latestProtocolVersion = "2025-06-18" | ||
|
|
||
| var supportedProtocolVersions = []string{latestProtocolVersion, "2025-03-26"} |
Contributor
There was a problem hiding this comment.
Don't we also support the 2024-11 version?
If we don't say that, what will that mean for SSE usage?
findleyr
approved these changes
Jul 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Negotiate the protocol version properly, and set the header on HTTP transports.
We follow the logic of the Typescript SDK.
On initialization, the client sends the latest version it can support, and accepts the version that the server returns if the client supports it. If not, the connection fails.
The server accepts the client's version unless it doesn't support it, in which case it replies with its latest version.
Fixes #103.