docs: fix the service example in the readme and examples/hello #127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jba
requested changes
Jul 14, 2025
Contributor
Author
|
I tried to pull the latest commit, and running build.sh, there was no diff in README.md. |
Contributor
|
My mistake. You want to edit internal/readme/server/server.go. Then run the script. |
Contributor
Author
|
Before I pull the latest commit and ran the script, I had already edited the internal/readme/server/server.go file in previous commit. And I didn't see any change in the README.md, I think the modification of README.md is the same as the script generation. |
jba
approved these changes
Jul 14, 2025
Contributor
|
Ah yes, you're good. Thank you for this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix an example using mcp tag instead of jsonschema.