Fix jsonrpc path and url #128
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsonrpc's github path notation and pkg.go.dev link url are broken.
Contributor
|
Thanks! But don't edit README.md, edit internal/readme/README.src.md and then run build.sh from that directory. |
jba
requested changes
Jul 14, 2025
Contributor
jba
left a comment
jba
left a comment
There was a problem hiding this comment.
edit internal/readme/README.src.md and run build.sh
Contributor
Author
|
Thank you and sorry jba. I retry it. |
jba
requested changes
Jul 14, 2025
Contributor
jba
left a comment
jba
left a comment
There was a problem hiding this comment.
I don't see README.src.md in your PR.
jsonrpc's github path notation and pkg.go.dev link url are broken.
Contributor
Author
|
I added internal/readme/README.src.md and ran ./build.sh on my PC and confirmed there were no errors. |
Contributor
Author
|
Thanks for merging me! I am looking forward to this go-sdk becoming GA! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jsonrpc's github path notation and pkg.go.dev link url are broken.