mcp: export Event #145
Merged
mcp: export Event #145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Export the Event type in preparation for providing user-definable storage for resumable streams. Also, move event code to a separate file. This PR is just renaming and code motion.
RoyceLeonD
approved these changes
Jul 17, 2025
There was a problem hiding this comment.
Just for my own understanding, we pulled out logic in sse.go, brought it into the exported Event and then updated it to use the new event to handle write and response. The SSE file itself is also doing things with client connection but we don't care about that in this PR, and we just want to pull out the event and streamable response handlers.
Contributor
Author
|
@RoyceLeonD yes. |
samthanawalla
approved these changes
Jul 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Export the Event type in preparation for providing user-definable storage for resumable streams.
Also, move event code to a separate file.
This PR is just renaming and code motion.