jsonschema: options for inference #185
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add ForOptions to hold options for schema inference. - Replace ForLax with ForOptions.IgnoreBadTypes. - Add an option to provide schemas for arbitrary types. - Provide a default mapping from types to schemas that includes stdlib types with MarshalJSON methods. - Add Schema.CloneSchemas. This is needed to make copies of the schemas in the above map: a schema cannot appear twice in a parent schema, because schema addresses matter when resolving internal references.
samthanawalla
previously approved these changes
Jul 29, 2025
findleyr
previously approved these changes
Jul 30, 2025
| TypeSchemas map[any]*Schema | ||
| } | ||
|
|
||
| // For constructs a JSON schema object for the given type argument. |
Contributor
There was a problem hiding this comment.
// If non-nil, the provided options configures certain aspects of this contruction, described below.
(we need to document somewhere that opts may be nil)
jsonschema/infer.go
Outdated
|
|
||
| // ForOptions are options for the [For] function. | ||
| type ForOptions struct { | ||
| // If IgnoreBadTypes is true, fields that can't be represented as a JSON Schema |
Contributor
There was a problem hiding this comment.
Is there any better word than 'Bad'? I'd say 'Unsupported' is better, but it's too long.
Probably Bad is best, I just wanted to note this decision.
Contributor
Author
There was a problem hiding this comment.
replaced with "Invalid"
findleyr
approved these changes
Jul 30, 2025
samthanawalla
approved these changes
Jul 31, 2025
BC-ACherednichenko
pushed a commit
to BC-ACherednichenko/go-sdk
that referenced
this pull request
Aug 5, 2025
- Add ForOptions to hold options for schema inference. - Replace ForLax with ForOptions.IgnoreBadTypes. - Add an option to provide schemas for arbitrary types. - Provide a default mapping from types to schemas that includes stdlib types with MarshalJSON methods. - Add Schema.CloneSchemas. This is needed to make copies of the schemas in the above map: a schema cannot appear twice in a parent schema, because schema addresses matter when resolving internal references.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ForOptions to hold options for schema inference.
Replace ForLax with ForOptions.IgnoreBadTypes.
Add an option to provide schemas for arbitrary types.
Provide a default mapping from types to schemas that includes stdlib types with MarshalJSON methods.
Add Schema.CloneSchemas. This is needed to make copies of the schemas in the above map: a schema cannot appear twice in a parent schema, because schema addresses matter when resolving internal references.