Implement json.Unmarshaler to CreateMessageResult #191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jba
requested changes
Jul 29, 2025
mcp/protocol.go
Outdated
| } | ||
|
|
||
| func (r *CreateMessageResult) UnmarshalJSON(data []byte) error { | ||
| type result CreateMessageResult |
Contributor
There was a problem hiding this comment.
add the comment "// avoid recursion"
Contributor
|
Thanks, good catch! |
francistm
force-pushed
the
feat/add-unmarshal-json-to-create-mesg-result
branch
from
ced57a9 to
b939d66
Compare
jba
previously approved these changes
Jul 30, 2025
Contributor
|
Please fix failing test. |
Contributor
Author
I've update the stub in unittest, should be working now |
jba
approved these changes
Jul 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When calling
ServerSession.CreateMessage, will get an json unmarshal error becauseCreateMessageResult.Contentis an interface, and it doesn't implementjson.Unmarshaller.Implement the
json.UnmarshallertoCreateMessageResult, let it able to unmarshal the client response without error