mcp/tool: duplicate tools should not error #295
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findleyr
reviewed
Aug 13, 2025
mcp/mcp_test.go
Outdated
| _, cs := basicConnection(t, func(s *Server) { | ||
| tool := &Tool{Name: "dup", InputSchema: &jsonschema.Schema{}} | ||
| s.AddTool(tool, nopHandler) | ||
| s.AddTool(tool, nopHandler) |
Contributor
There was a problem hiding this comment.
The bug was only in the json schema resolution, right? Meaning, it would also be reprouced if we use a different Tool instance? In that case, use a different description and assert that the tool value is the last tool that was added, by checking its description.
Contributor
Author
There was a problem hiding this comment.
Good suggestion. Made the change and tests are passing.
mcp/tool.go
Outdated
| if orig == nil { | ||
| return nil, nil | ||
| } | ||
| b, err := json.Marshal(orig) |
Contributor
There was a problem hiding this comment.
I'm not sure if this is the best way to handle this, but @jba will know. Added him as a reviewer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mcp/tool: duplicate tools should not error
These changes touch SetSchema, since that was the best place that I could find resolve this issue.
This is my first time contributing to open source, I hope that I've followed expected formatting and if not I would happy to fix whatever you all need :)
All tests are passing and I duplicated tools in one of the examples(was hello/) and it ran without error.
Fixes #217